Adding optimization to avoid image copy in SkSurface copy on write when content is discardable

include/core/SkSurface.h

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkSurface_DEFINED
 #define SkSurface_DEFINED
 
@@ skipping 61 matching lines @@
      *  surface. Each time the content is changed changed, either by drawing
      *  into this surface, or explicitly calling notifyContentChanged()) this
      *  method will return a new value.
      *
      *  If this surface is empty (i.e. has a zero-dimention), this will return
      *  0.
      */
     uint32_t generationID();
 
     /**
-     *  Call this if the contents have changed. This will (lazily) force a new
+     *  Call this if the contents are about to change. This will (lazily) force a new
      *  value to be returned from generationID() when it is called next.
+     *  @param canDiscardContents Should be true if upcoming changes will clear
+     *      or occlude prior contents, thus making them discardable.
      */

[reed1, 2013/04/18 14:48:33]

Perhaps an enum or bit-field, so at the call-site we don't have to
guess/remember what true/false mean?

-    void notifyContentChanged();
+    void notifyContentWillChange(bool canDiscardContents);
 
     /**
      *  Return a canvas that will draw into this surface. This will always
      *  return the same canvas for a given surface, and is manged/owned by the
      *  surface. It should not be used when its parent surface has gone out of
      *  scope.
      */
     SkCanvas* getCanvas();
 
     /**
@@ skipping 37 matching lines @@
 
 private:
     const int   fWidth;
     const int   fHeight;
     uint32_t    fGenerationID;
 
     typedef SkRefCnt INHERITED;
 };
 
 #endif