chrome/browser/extensions/extension_crash_recovery_browsertest.cc - Issue 14063013: Disable ExtensionCrashRecoveryTest.ReloadTabsWithBackgroundPage on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

Issue 14063013: Disable ExtensionCrashRecoveryTest.ReloadTabsWithBackgroundPage on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

===================================================================

--- chrome/browser/extensions/extension_crash_recovery_browsertest.cc (revision 194554)

+++ chrome/browser/extensions/extension_crash_recovery_browsertest.cc (working copy)

@@ -541,11 +541,12 @@

}

// Disabled on aura as flakey: http://crbug.com/169622

-#if defined(USE_AURA)

+// Failing on Windows after Blink roll: http://crbug.com/232340

+#if defined(USE_AURA) || defined(OS_WIN)

#define MAYBE_ReloadTabsWithBackgroundPage DISABLED_ReloadTabsWithBackgroundPage

#else

#define MAYBE_ReloadTabsWithBackgroundPage ReloadTabsWithBackgroundPage

-#endif // defined(OS_LINUX)

+#endif

// Test that when an extension with a background page that has a tab open

// crashes, the tab stays open, and reloading it reloads the extension.

« no previous file with comments | « no previous file | no next file » | no next file with comments »