Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1406283002: Include resources directory in google3 sync. (Closed)

Created:
5 years, 2 months ago by dogben
Modified:
5 years, 2 months ago
Reviewers:
mtklein
CC:
reviews_skia.org, jcgregorio, melanielc_google.com
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Include resources directory in google3 sync. Also other minor improvements in sync scripts. In BUILD.public, include all files under resources as data dependencies for DM. Omit newly failing DM tests and add newly passing DM tests. Adds the OpenClipart "license" to LICENSE per comment in google3 CL 100158380. Corresponding google3 CL is 105602927. BUG=skia: Committed: https://skia.googlesource.com/skia/+/964eebae2dc83fa0ef780f62faa90377e2198c5d

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -19 lines) Patch
M BUILD.public View 1 chunk +2 lines, -3 lines 1 comment Download
M LICENSE View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/create_skia_google3_client.sh View 2 chunks +5 lines, -2 lines 0 comments Download
M tools/get_skia_lkgr.sh View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/git_clone_to_google3.sh View 2 chunks +5 lines, -8 lines 0 comments Download
M tools/sync_google3.sh View 3 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dogben
5 years, 2 months ago (2015-10-16 19:49:09 UTC) #5
mtklein
How do you feel about starting out by just disabling tests that require resources/?
5 years, 2 months ago (2015-10-16 21:11:39 UTC) #6
dogben
On 2015/10/16 at 21:11:39, mtklein wrote: > How do you feel about starting out by ...
5 years, 2 months ago (2015-10-17 19:45:41 UTC) #7
mtklein
lgtm https://codereview.chromium.org/1406283002/diff/60001/BUILD.public File BUILD.public (right): https://codereview.chromium.org/1406283002/diff/60001/BUILD.public#newcode277 BUILD.public:277: "--match ~FontMgr ~Scalar ~Canvas ~Codec_stripes ~Codec_Dimensions ~Codec ~Stream ...
5 years, 2 months ago (2015-10-19 20:47:01 UTC) #8
dogben
On 2015/10/19 at 20:47:01, mtklein wrote: > lgtm > > https://codereview.chromium.org/1406283002/diff/60001/BUILD.public > File BUILD.public (right): ...
5 years, 2 months ago (2015-10-19 21:07:51 UTC) #9
mtklein
On 2015/10/19 21:07:51, Ben Wagner wrote: > On 2015/10/19 at 20:47:01, mtklein wrote: > > ...
5 years, 2 months ago (2015-10-19 21:11:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406283002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406283002/60001
5 years, 2 months ago (2015-10-20 19:50:27 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 20:00:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://skia.googlesource.com/skia/+/964eebae2dc83fa0ef780f62faa90377e2198c5d

Powered by Google App Engine
This is Rietveld 408576698