Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1406253007: XFA: Segv in CFXJSE_RuntimeData::Get() (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang, jun_fang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: Segv in CFXJSE_RuntimeData::Get() Crash occurs when JS is first entered from the FXJSE_ side, instead of the FXJS_ side. Added initializaton call to FXJSE_. BUG=pdfium:259 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6fc7919796b68d5264030250875dce2358605af1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M xfa/src/fxjse/src/runtime.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review. Test blocker.
5 years, 1 month ago (2015-10-30 16:25:22 UTC) #2
Lei Zhang
lgtm
5 years, 1 month ago (2015-10-30 16:28:45 UTC) #3
Tom Sepez
5 years, 1 month ago (2015-10-30 17:28:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6fc7919796b68d5264030250875dce2358605af1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698