Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1406243002: Revert of [WebViewLayoutTest] Fix potential rounding error in testBatteryApi() layout test. (Closed)

Created:
5 years, 2 months ago by johnme
Modified:
5 years, 2 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [WebViewLayoutTest] Fix potential rounding error in testBatteryApi() layout test. (patchset #1 id:1 of https://codereview.chromium.org/1394303007/ ) Reason for revert: This patch caused WebViewLayoutTest#testBatteryApi to fail consistently on https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20L%20%28dbg%29/builds/3317 onwards. Original issue's description: > [WebViewLayoutTest] Fix potential rounding error in testBatteryApi() layout test. > > The battery.level precision test isInteger(battery.level * 100) can > occasionally fail due to rounding error, > e.g. (0.58 * 100) % 1 = 0.9999999999999929. > This patch uses toPrecision and toString methods instead to correct > this issue. > > BUG= > > Committed: https://crrev.com/beebf8aac8acd93bd045d94a5835e12b4992176e > Cr-Commit-Position: refs/heads/master@{#354498} TBR=mvanouwerkerk@chromium.org,timvolodine@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/c80ce31ead16f31e4f1693e782c23a1a24865ad8 Cr-Commit-Position: refs/heads/master@{#354510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M android_webview/tools/WebViewShell/test/blink-apis/battery-status/battery-callback.html View 3 chunks +9 lines, -2 lines 0 comments Download
M android_webview/tools/WebViewShell/test/blink-apis/battery-status/battery-callback-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
johnme
Created Revert of [WebViewLayoutTest] Fix potential rounding error in testBatteryApi() layout test.
5 years, 2 months ago (2015-10-16 14:00:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406243002/1
5 years, 2 months ago (2015-10-16 14:00:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 14:01:32 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 14:03:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c80ce31ead16f31e4f1693e782c23a1a24865ad8
Cr-Commit-Position: refs/heads/master@{#354510}

Powered by Google App Engine
This is Rietveld 408576698