Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 140623005: Set MinimumRequiredVersion for XP support on x86 builds. (Closed)

Created:
6 years, 10 months ago by grt (UTC plus 2)
Modified:
6 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Set MinimumRequiredVersion for XP support on x86 builds. BUG=297971 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
grt (UTC plus 2)
6 years, 10 months ago (2014-02-05 19:49:05 UTC) #1
scottmg
LGTM, thanks for testing on XP.
6 years, 10 months ago (2014-02-05 19:49:55 UTC) #2
grt (UTC plus 2)
On 2014/02/05 19:49:55, scottmg wrote: > LGTM, thanks for testing on XP. Rebuilding now. Will ...
6 years, 10 months ago (2014-02-05 19:50:47 UTC) #3
grt (UTC plus 2)
The CQ bit was checked by grt@chromium.org
6 years, 10 months ago (2014-02-05 22:56:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/140623005/1
6 years, 10 months ago (2014-02-05 22:57:55 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 09:49:22 UTC) #6
Message was sent while issue was closed.
Change committed as 249318

Powered by Google App Engine
This is Rietveld 408576698