[Android]: Add content_gl_tests to test_runner.py gtest suite.

ui/gfx/gfx.gyp

Index: ui/gfx/gfx.gyp
diff --git a/ui/gfx/gfx.gyp b/ui/gfx/gfx.gyp
index 66c384eb2787b8d85a352a28aa96ce5913c5223b..bfe21a0b9249a570f9b0460f7641bfa8606a4086 100644
--- a/ui/gfx/gfx.gyp
+++ b/ui/gfx/gfx.gyp
@@ -68,7 +68,7 @@
     #             ui_unittests.

[bulach, 2014/01/16 11:58:03]

if this TODO is not obsolete :) looks like it's already being built and executed
as part of ui_unittests?

http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%...

by changing it to gtest_target_type, it'd actually *remove* these tests from
other platforms until they're listed in the buildbot steps, etc... i.e., on
desktop it will be built as an "executable" rather than "static library", and
nobody will execute this test suite..

I'm not sure if original reason for this TODO was just so these tests could be
easily ran in the bots or if there are more complications, but anyways, I think
it should be done as a separate series of patches... wdyt?

[r.kasibhatla, 2014/01/16 12:39:16]

Sorry, I didn't notice that gfx_geometry_unittests were part of ui_unittests :).
Agreed, separating gfx_geometry from ui unittests can be taken to separate patch
(if you feel separation is ok).
Aah, you mean if I separate gfx_geometry_unittests from ui_unittests, we need to
update buildbot scripts as well to ensure the new binary is also executed now. I
am not sure how to get the buildbot scripts modified for the change? Any
pointers?
I actually wanted content_gl_tests and gfx_geometry_unittests to be ran for
Android also. Since, the core issue is now separation of gfx_geometry_unittests
from ui_unittests, I agree it should be done separately. 
Shall I modify the patch to just add content_gl_tests to gtest_config.py.
As for gfx_geometry_unittests, what is your suggestion? Should I also check with
beng about separation and if he is also ok with the separation?

[bulach, 2014/01/16 14:06:44]

yeah, the tests from gfx_geometry_unittests are already running for android, so
I think it's less pressing to put on a target of its own...
it's a bit complicated, you'd probably better create a bug against
infrastructure and ask that team to take care of it...
there are implications about load, it has to run on try servers, commit queue,
etc...
phajdan.jr would be a good person to ask.
yes, I think that's the best way to go.
since the gfx_geometry_unittests are already running (although under a different
name), I'd do that separately as it'll be a big effort on its own.. :)
perhaps ping beng@ first, and if it's important to keep them separately, then
create a "feature request" for infrastructure and see what they say?
I don't have any concrete pointers, but for starters, all these files that
reference "ui_unittests" would have to change to also add "gfx_unittests":

https://code.google.com/p/chromium/codesearch#search/&q=file:.*cfg%20%5C'ui_u...

     {
       'target_name': 'gfx_geometry_unittests',
-      'type': 'static_library',
+      'type': '<(gtest_target_type)',
       'dependencies': [
         '<(DEPTH)/base/base.gyp:base',
         '<(DEPTH)/base/base.gyp:test_support_base',
@@ -493,5 +493,19 @@
        },
      ],
     }],
+    ['OS == "android" and gtest_target_type == "shared_library"', {
+      'targets': [
+        {
+          'target_name': 'gfx_geometry_unittests_apk',
+          'type': 'none',
+          'dependencies': [ 'gfx_geometry_unittests', ],
+          'variables': {
+            'test_suite_name': 'gfx_geometry_unittests',
+            'input_shlib_path': '<(SHARED_LIB_DIR)/<(SHARED_LIB_PREFIX)gfx_geometry_unittests<(SHARED_LIB_SUFFIX)',
+          },
+          'includes': [ '../../build/apk_test.gypi', ],
+        },
+      ],
+    }],
   ],
 }