Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1406223010: Revert "Revert of [turbofan] Remove redundant code.[...]" (Closed)

Created:
5 years, 1 month ago by Mircea Trofin
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Revert of [turbofan] Remove redundant code. (patchset #1 id:1 of https://codereview.chromium.org/1428943004/ )" This reverts commit 5f4828a12db3f04f8b92f10724c5c18dd5efc7e7. Maintaining the behavior of processing both ranges with spill ranges, as well as those with spill operands. BUG= Committed: https://crrev.com/b10e8506ac01b08a142fcc3508f2d44012bbc2bb Cr-Commit-Position: refs/heads/master@{#31924}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -27 lines) Patch
M src/compiler/greedy-allocator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/register-allocator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 chunks +6 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jarin
lgtm
5 years, 1 month ago (2015-11-04 09:27:55 UTC) #3
Mircea Trofin
On 2015/11/04 09:27:55, Jarin wrote: > lgtm PTAL - greedy doesn't like eagerly pre-spilling ranges, ...
5 years, 1 month ago (2015-11-04 16:13:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406223010/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406223010/40001
5 years, 1 month ago (2015-11-10 17:50:04 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-10 18:06:26 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 18:06:41 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b10e8506ac01b08a142fcc3508f2d44012bbc2bb
Cr-Commit-Position: refs/heads/master@{#31924}

Powered by Google App Engine
This is Rietveld 408576698