content/child/blink_platform_impl.cc - Issue 1406213005: [tracing] Add names to memory-infra dumpers for debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/blink_platform_impl.cc

Issue 1406213005: [tracing] Add names to memory-infra dumpers for debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@memory-infra-runtime

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/blink_platform_impl.h ('k') | content/child/child_discardable_shared_memory_manager.cc » ('j') | third_party/WebKit/Source/web/WebKit.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/blink_platform_impl.cc

diff --git a/content/child/blink_platform_impl.cc b/content/child/blink_platform_impl.cc

index 1a1cc6781df243748829e2392f188715b1ae2923..9d2e995d7728ab46ad2da5de8c25608bb2229873 100644

--- a/content/child/blink_platform_impl.cc

+++ b/content/child/blink_platform_impl.cc

@@ -705,7 +705,7 @@ void BlinkPlatformImpl::updateTraceEventDuration(

}

void BlinkPlatformImpl::registerMemoryDumpProvider(

- blink::WebMemoryDumpProvider* wmdp) {

+ blink::WebMemoryDumpProvider* wmdp, const char* name) {

WebMemoryDumpProviderAdapter* wmdp_adapter =

new WebMemoryDumpProviderAdapter(wmdp);

bool did_insert =

@@ -714,7 +714,7 @@ void BlinkPlatformImpl::registerMemoryDumpProvider(

return;

wmdp_adapter->set_is_registered(true);

base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(

- wmdp_adapter, base::ThreadTaskRunnerHandle::Get());

+ wmdp_adapter, name, base::ThreadTaskRunnerHandle::Get());

}

void BlinkPlatformImpl::unregisterMemoryDumpProvider(