Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: content/browser/browser_main_loop.cc

Issue 1406213005: [tracing] Add names to memory-infra dumpers for debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@memory-infra-runtime
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_main_loop.cc
diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc
index 32298516aab616ada664c5d6989ff3dcb27c6803..8fd44e7eabaf84a98b4c22a7e2365d99635b8ecc 100644
--- a/content/browser/browser_main_loop.cc
+++ b/content/browser/browser_main_loop.cc
@@ -667,11 +667,11 @@ void BrowserMainLoop::PostMainMessageLoopStart() {
// Enable memory-infra dump providers.
InitSkiaEventTracer();
base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
- HostSharedBitmapManager::current());
+ HostSharedBitmapManager::current(), "HostSharedBitmapManager");
base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
- skia::SkiaMemoryDumpProvider::GetInstance());
+ skia::SkiaMemoryDumpProvider::GetInstance(), "Skia");
base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
- sql::SqlMemoryDumpProvider::GetInstance());
+ sql::SqlMemoryDumpProvider::GetInstance(), "Sql");
#if defined(TCMALLOC_TRACE_MEMORY_SUPPORTED)
trace_memory_controller_.reset(new base::trace_event::TraceMemoryController(
@@ -1195,10 +1195,11 @@ int BrowserMainLoop::BrowserThreadsStarted() {
// unregistration happens on the IO thread (See
// BrowserProcessSubThread::IOThreadPreCleanUp).
base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
- BrowserGpuMemoryBufferManager::current(), io_thread_->task_runner());
+ BrowserGpuMemoryBufferManager::current(), "BrowserGpuMemoryBufferManager",
+ io_thread_->task_runner());
#if defined(OS_ANDROID)
base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
- tracing::GraphicsMemoryDumpProvider::GetInstance());
+ tracing::GraphicsMemoryDumpProvider::GetInstance(), "AndroidGraphics");
#endif
{

Powered by Google App Engine
This is Rietveld 408576698