gin/v8_isolate_memory_dump_provider.cc - Issue 1406213005: [tracing] Add names to memory-infra dumpers for debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/v8_isolate_memory_dump_provider.cc

Issue 1406213005: [tracing] Add names to memory-infra dumpers for debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@memory-infra-runtime

Patch Set: Rebase + fix android Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/v8_isolate_memory_dump_provider.cc

diff --git a/gin/v8_isolate_memory_dump_provider.cc b/gin/v8_isolate_memory_dump_provider.cc

index ecbf5fffabfd8cec0f0e73f938a04bd1cdec909e..79c7177a9b2c127f33b9f4190a43b9d997005da5 100644

--- a/gin/v8_isolate_memory_dump_provider.cc

+++ b/gin/v8_isolate_memory_dump_provider.cc

@@ -17,7 +17,7 @@ V8IsolateMemoryDumpProvider::V8IsolateMemoryDumpProvider(

IsolateHolder* isolate_holder)

: isolate_holder_(isolate_holder) {

base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(

- this, base::ThreadTaskRunnerHandle::Get());

+ this, "V8Isolate", base::ThreadTaskRunnerHandle::Get());

}

V8IsolateMemoryDumpProvider::~V8IsolateMemoryDumpProvider() {

« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | gpu/command_buffer/client/cmd_buffer_helper.cc » ('j') | no next file with comments »