Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: content/browser/browser_main_loop.cc

Issue 1406213005: [tracing] Add names to memory-infra dumpers for debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@memory-infra-runtime
Patch Set: Rebase + fix android Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_main_loop.cc
diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc
index 32298516aab616ada664c5d6989ff3dcb27c6803..2dd1dfcbac165ab765f1635c5aba2e4712c42b8c 100644
--- a/content/browser/browser_main_loop.cc
+++ b/content/browser/browser_main_loop.cc
@@ -667,11 +667,11 @@ void BrowserMainLoop::PostMainMessageLoopStart() {
// Enable memory-infra dump providers.
InitSkiaEventTracer();
base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
- HostSharedBitmapManager::current());
+ HostSharedBitmapManager::current(), "HostSharedBitmapManager", nullptr);
base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
- skia::SkiaMemoryDumpProvider::GetInstance());
+ skia::SkiaMemoryDumpProvider::GetInstance(), "Skia", nullptr);
base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
- sql::SqlMemoryDumpProvider::GetInstance());
+ sql::SqlMemoryDumpProvider::GetInstance(), "Sql", nullptr);
#if defined(TCMALLOC_TRACE_MEMORY_SUPPORTED)
trace_memory_controller_.reset(new base::trace_event::TraceMemoryController(
@@ -1195,10 +1195,12 @@ int BrowserMainLoop::BrowserThreadsStarted() {
// unregistration happens on the IO thread (See
// BrowserProcessSubThread::IOThreadPreCleanUp).
base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
- BrowserGpuMemoryBufferManager::current(), io_thread_->task_runner());
+ BrowserGpuMemoryBufferManager::current(), "BrowserGpuMemoryBufferManager",
+ io_thread_->task_runner());
#if defined(OS_ANDROID)
base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
- tracing::GraphicsMemoryDumpProvider::GetInstance());
+ tracing::GraphicsMemoryDumpProvider::GetInstance(), "AndroidGraphics",
+ nullptr);
#endif
{
« no previous file with comments | « components/tracing/child_trace_message_filter_browsertest.cc ('k') | content/browser/tracing/memory_tracing_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698