Reset readystates when webmediaplayer is cleared

third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 614c6ce029563ab390b6395af1f1e283eed2f81d..17ec562fc62d5d89b961fae1bf738cad10424b5c 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -3044,8 +3044,11 @@ void HTMLMediaElement::userCancelledLoad()
     // 1 - The user agent should cancel the fetching process.
     clearMediaPlayer(-1);
 
-    if (m_networkState == NETWORK_EMPTY || m_completelyLoaded || m_isFinalizing)
+    if (m_networkState == NETWORK_EMPTY || m_completelyLoaded || m_isFinalizing) {
+        m_readyState = HAVE_NOTHING;

[philipj_slow, 2015/10/20 11:24:53]

Shouldn't the readyState be reset unconditionally? I guess this happens here
merely so that it happens before the function returns, but moving up the "Reset
m_readyState since m_webMediaPlayer is gone" bit to right after the
clearMediaPlayer(-1) call would be more clear I think.

[Srirama, 2015/10/20 11:31:34]

I thought about that, but it will affect step4 in this function. We are
resetting networkstate based on readystate value. So is it fine to move it up?

[philipj_slow, 2015/10/20 11:52:00]

Oh, that's annoying. I think the problem here is that the spec text is written
in a way that makes sense if you merely stop the network activity but still
allow the data already fetched to be played, which implies keeping the player
alive. However, the first thing we do is to clear the player...

Have you dug into the purpose of this early return? Is it really a good idea to
skip over the `m_currentSourceNode = nullptr` step, for example?

+        m_readyStateMaximum = HAVE_NOTHING;
         return;
+    }
 
     // 2 - Set the error attribute to a new MediaError object whose code attribute is set to MEDIA_ERR_ABORTED.
     m_error = MediaError::create(MediaError::MEDIA_ERR_ABORTED);
@@ -3072,6 +3075,7 @@ void HTMLMediaElement::userCancelledLoad()
 
     // Reset m_readyState since m_webMediaPlayer is gone.
     m_readyState = HAVE_NOTHING;
+    m_readyStateMaximum = HAVE_NOTHING;
     invalidateCachedTime();
     updateMediaController();
     cueTimeline().updateActiveCues(0);