Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1406183003: Reset readystates when webmediaplayer is cleared (Closed)

Created:
5 years, 2 months ago by Srirama
Modified:
5 years, 2 months ago
Reviewers:
philipj_slow
CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset readystates when webmediaplayer is cleared WebMediaPlayer is going out of sync with m_readyState which is causing crashes. Reset the ready states when WebMediaPlayer is cleared. BUG=537013, 541520 Committed: https://crrev.com/25778e5a479379a937e9405081f696d1875b73f3 Cr-Commit-Position: refs/heads/master@{#355076}

Patch Set 1 #

Total comments: 5

Patch Set 2 : update as per review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/media/video-move-to-new-document-crash.html View 1 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
Srirama
PTAL.
5 years, 2 months ago (2015-10-20 10:44:43 UTC) #5
philipj_slow
https://codereview.chromium.org/1406183003/diff/40001/third_party/WebKit/LayoutTests/media/video-move-to-new-document.html File third_party/WebKit/LayoutTests/media/video-move-to-new-document.html (right): https://codereview.chromium.org/1406183003/diff/40001/third_party/WebKit/LayoutTests/media/video-move-to-new-document.html#newcode2 third_party/WebKit/LayoutTests/media/video-move-to-new-document.html:2: <title>move video element to new document</title> Can you put ...
5 years, 2 months ago (2015-10-20 11:24:54 UTC) #6
Srirama
https://codereview.chromium.org/1406183003/diff/40001/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/1406183003/diff/40001/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode3048 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3048: m_readyState = HAVE_NOTHING; On 2015/10/20 11:24:53, philipj wrote: > ...
5 years, 2 months ago (2015-10-20 11:31:34 UTC) #7
philipj_slow
https://codereview.chromium.org/1406183003/diff/40001/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/1406183003/diff/40001/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode3048 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3048: m_readyState = HAVE_NOTHING; On 2015/10/20 11:31:34, Srirama wrote: > ...
5 years, 2 months ago (2015-10-20 11:52:01 UTC) #8
Srirama
On 2015/10/20 11:52:01, philipj wrote: > https://codereview.chromium.org/1406183003/diff/40001/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp > File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): > > https://codereview.chromium.org/1406183003/diff/40001/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode3048 > ...
5 years, 2 months ago (2015-10-20 13:07:14 UTC) #9
philipj_slow
On 2015/10/20 13:07:14, Srirama wrote: > On 2015/10/20 11:52:01, philipj wrote: > > > https://codereview.chromium.org/1406183003/diff/40001/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ...
5 years, 2 months ago (2015-10-20 13:15:14 UTC) #10
Srirama
On 2015/10/20 13:15:14, philipj wrote: > On 2015/10/20 13:07:14, Srirama wrote: > > On 2015/10/20 ...
5 years, 2 months ago (2015-10-20 13:59:20 UTC) #11
philipj_slow
On 2015/10/20 13:59:20, Srirama wrote: > On 2015/10/20 13:15:14, philipj wrote: > > On 2015/10/20 ...
5 years, 2 months ago (2015-10-20 14:16:19 UTC) #12
Srirama
Modified as suggested. PTAL. Hope you are not having hard time reviewing my patches. https://codereview.chromium.org/1406183003/diff/40001/third_party/WebKit/LayoutTests/media/video-move-to-new-document.html ...
5 years, 2 months ago (2015-10-20 14:32:32 UTC) #13
philipj_slow
LGTM, I've also verified that the test crashes for me locally without the fix. No ...
5 years, 2 months ago (2015-10-20 14:45:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406183003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406183003/60001
5 years, 2 months ago (2015-10-20 16:24:44 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 2 months ago (2015-10-20 16:35:05 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 16:36:26 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25778e5a479379a937e9405081f696d1875b73f3
Cr-Commit-Position: refs/heads/master@{#355076}

Powered by Google App Engine
This is Rietveld 408576698