Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1406163007: Replaced deprecated compiler module usage with the ast module

Created:
5 years, 1 month ago by AWhetter
Modified:
3 years, 8 months ago
Reviewers:
methane
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

The compiler module was deprecated back in Python 2.6 (source: https://docs.python.org/2.7/library/compiler.html), so I've replaced it's usage with funcionality from the now preferred ast module (https://docs.python.org/2.7/library/ast.html).

Patch Set 1 #

Patch Set 2 : Rebased with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) #

Patch Set 3 : Fixed rebase upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -29 lines) Patch
M pylib/gyp/input.py View 1 2 2 chunks +17 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
AWhetter
5 years, 1 month ago (2015-11-06 20:51:12 UTC) #2
AWhetter
4 years, 8 months ago (2016-04-09 15:37:35 UTC) #3
methane
3 years, 8 months ago (2017-04-06 10:26:23 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698