Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1587)

Issue 1406163002: Revert of VectorICs: turn on vectors for STORE and KEYED_STORE ics. (Closed)

Created:
5 years, 2 months ago by mvstanton
Modified:
5 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of VectorICs: turn on vectors for STORE and KEYED_STORE ics. (patchset #1 id:1 of https://codereview.chromium.org/1396523005/ ) Reason for revert: We harvested enough information now about the windows crash. We'll investigate that and reland when fixed. Original issue's description: > VectorICs: turn on vectors for STORE and KEYED_STORE ics. > > R=jkummerow@chromium.org > BUG= > > Committed: https://crrev.com/52225f39df578e77b4804506ca4bc15e096f5cab > Cr-Commit-Position: refs/heads/master@{#31252} > > Committed: https://crrev.com/31487015de401892b4d12b5faef0c47c201308da > Cr-Commit-Position: refs/heads/master@{#31305} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/ddf5832ac67a985aef8a35479134c9067fe19dda Cr-Commit-Position: refs/heads/master@{#31325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Created Revert of VectorICs: turn on vectors for STORE and KEYED_STORE ics.
5 years, 2 months ago (2015-10-16 08:25:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406163002/1
5 years, 2 months ago (2015-10-16 08:25:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 08:25:32 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 08:25:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddf5832ac67a985aef8a35479134c9067fe19dda
Cr-Commit-Position: refs/heads/master@{#31325}

Powered by Google App Engine
This is Rietveld 408576698