Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1406153010: [turbofan] Initial support for transitioning stores. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Initial support for transitioning stores. Add support for stores that transition to writable data fields, based on the BeginRegion/FinishRegion mechanism for atomic regions in the scheduler. This is early work and still a bit rough around the edges, and similar to regular stores, we don't support transitioning stores to double fields yet. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/a0b8650e6555652267698481873beecd263bd463 Cr-Commit-Position: refs/heads/master@{#31645}

Patch Set 1 #

Patch Set 2 : Fix non-inobject properties. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -39 lines) Patch
M src/compilation-dependencies.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compilation-dependencies.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 16 chunks +140 lines, -38 lines 2 comments Download
M src/type-cache.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-29 06:54:59 UTC) #1
Benedikt Meurer
Hey Jaro, This is the initial version of transitioning stores. Please take a look. Thanks, ...
5 years, 1 month ago (2015-10-29 07:34:16 UTC) #4
Jarin
lgtm. https://codereview.chromium.org/1406153010/diff/20001/src/compiler/js-native-context-specialization.cc File src/compiler/js-native-context-specialization.cc (right): https://codereview.chromium.org/1406153010/diff/20001/src/compiler/js-native-context-specialization.cc#newcode492 src/compiler/js-native-context-specialization.cc:492: // Check if the {receiver_map} has a data ...
5 years, 1 month ago (2015-10-29 09:02:33 UTC) #5
Benedikt Meurer
https://codereview.chromium.org/1406153010/diff/20001/src/compiler/js-native-context-specialization.cc File src/compiler/js-native-context-specialization.cc (right): https://codereview.chromium.org/1406153010/diff/20001/src/compiler/js-native-context-specialization.cc#newcode492 src/compiler/js-native-context-specialization.cc:492: // Check if the {receiver_map} has a data transition ...
5 years, 1 month ago (2015-10-29 09:03:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406153010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406153010/20001
5 years, 1 month ago (2015-10-29 09:04:25 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-29 09:05:54 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 09:06:36 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0b8650e6555652267698481873beecd263bd463
Cr-Commit-Position: refs/heads/master@{#31645}

Powered by Google App Engine
This is Rietveld 408576698