Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Side by Side Diff: third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp

Issue 1406133005: Calculate paint invalidation rect for scrollbars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 6
7 #include "core/frame/RootFrameViewport.h" 7 #include "core/frame/RootFrameViewport.h"
8 8
9 #include "core/layout/ScrollAlignment.h" 9 #include "core/layout/ScrollAlignment.h"
10 #include "platform/geometry/DoubleRect.h" 10 #include "platform/geometry/DoubleRect.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 82
83 void setScrollOffset(const IntPoint& offset, ScrollType) override { m_scroll Position = offset; } 83 void setScrollOffset(const IntPoint& offset, ScrollType) override { m_scroll Position = offset; }
84 void setScrollOffset(const DoublePoint& offset, ScrollType) override { m_scr ollPosition = offset; } 84 void setScrollOffset(const DoublePoint& offset, ScrollType) override { m_scr ollPosition = offset; }
85 bool shouldUseIntegerScrollOffset() const override { return true; } 85 bool shouldUseIntegerScrollOffset() const override { return true; }
86 bool isActive() const override { return true; } 86 bool isActive() const override { return true; }
87 bool isScrollCornerVisible() const override { return true; } 87 bool isScrollCornerVisible() const override { return true; }
88 IntRect scrollCornerRect() const override { return IntRect(); } 88 IntRect scrollCornerRect() const override { return IntRect(); }
89 bool scrollbarsCanBeActive() const override { return true; } 89 bool scrollbarsCanBeActive() const override { return true; }
90 IntRect scrollableAreaBoundingBox() const override { return IntRect(); } 90 IntRect scrollableAreaBoundingBox() const override { return IntRect(); }
91 bool shouldPlaceVerticalScrollbarOnLeft() const override { return true; } 91 bool shouldPlaceVerticalScrollbarOnLeft() const override { return true; }
92 void invalidateScrollbarRect(Scrollbar*, const IntRect&) override { } 92 void scrollControlWasSetNeedsPaintInvalidation() override { }
93 void invalidateScrollCornerRect(const IntRect&) override { }
94 GraphicsLayer* layerForContainer() const override { return nullptr; } 93 GraphicsLayer* layerForContainer() const override { return nullptr; }
95 GraphicsLayer* layerForScrolling() const override { return nullptr; } 94 GraphicsLayer* layerForScrolling() const override { return nullptr; }
96 GraphicsLayer* layerForHorizontalScrollbar() const override { return nullptr ; } 95 GraphicsLayer* layerForHorizontalScrollbar() const override { return nullptr ; }
97 GraphicsLayer* layerForVerticalScrollbar() const override { return nullptr; } 96 GraphicsLayer* layerForVerticalScrollbar() const override { return nullptr; }
98 bool userInputScrollable(ScrollbarOrientation orientation) const override 97 bool userInputScrollable(ScrollbarOrientation orientation) const override
99 { 98 {
100 return orientation == HorizontalScrollbar ? m_userInputScrollableX : m_u serInputScrollableY; 99 return orientation == HorizontalScrollbar ? m_userInputScrollableX : m_u serInputScrollableY;
101 } 100 }
102 101
103 DoublePoint clampedScrollOffset(const DoublePoint& offset) 102 DoublePoint clampedScrollOffset(const DoublePoint& offset)
(...skipping 386 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 rootFrameViewport->setScrollPosition(DoublePoint(40, 40), UserScroll); 489 rootFrameViewport->setScrollPosition(DoublePoint(40, 40), UserScroll);
491 EXPECT_POINT_EQ(DoublePoint(40, 40), visualViewport->scrollPositionDouble()) ; 490 EXPECT_POINT_EQ(DoublePoint(40, 40), visualViewport->scrollPositionDouble()) ;
492 EXPECT_POINT_EQ(DoublePoint(0, 0), layoutViewport->scrollPositionDouble()); 491 EXPECT_POINT_EQ(DoublePoint(0, 0), layoutViewport->scrollPositionDouble());
493 492
494 rootFrameViewport->setScrollPosition(DoublePoint(60, 60), ProgrammaticScroll ); 493 rootFrameViewport->setScrollPosition(DoublePoint(60, 60), ProgrammaticScroll );
495 EXPECT_POINT_EQ(DoublePoint(50, 50), visualViewport->scrollPositionDouble()) ; 494 EXPECT_POINT_EQ(DoublePoint(50, 50), visualViewport->scrollPositionDouble()) ;
496 EXPECT_POINT_EQ(DoublePoint(10, 10), layoutViewport->scrollPositionDouble()) ; 495 EXPECT_POINT_EQ(DoublePoint(10, 10), layoutViewport->scrollPositionDouble()) ;
497 } 496 }
498 497
499 } // namespace blink 498 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/RootFrameViewport.cpp ('k') | third_party/WebKit/Source/core/frame/VisualViewport.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698