Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h

Issue 1406133005: Calculate paint invalidation rect for scrollbars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NeedsRebaselines for mac and windows etc Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef PaintInvalidationCapableScrollableArea_h
6 #define PaintInvalidationCapableScrollableArea_h
7
8 #include "core/CoreExport.h"
9 #include "platform/geometry/LayoutRect.h"
10 #include "platform/scroll/ScrollableArea.h"
11
12 namespace blink {
13
14 class LayoutBox;
15 class LayoutBoxModelObject;
16 class LayoutScrollbarPart;
17 class PaintInvalidationContainer;
18 class PaintInvalidationState;
19
20 // Base class of FrameView and PaintLayerScrollableArea to share paint invalidat ion code.
21 // TODO(wangxianzhu): Combine this into PaintLayerScrollableArea when FrameView no longer scrolls.
22 class CORE_EXPORT PaintInvalidationCapableScrollableArea : public ScrollableArea {
23 public:
24 // The LayoutBox parameter is the LayoutView of a FrameView if the scrollbar s belong to the FrameView,
25 // or the box() of a PaintLayerScrollbarArea if the scrollbars belong to the PaintLayerScrollableArea.
26 void willRemoveScrollbar(LayoutBox&, Scrollbar*, ScrollbarOrientation);
chrishtr 2015/11/17 00:44:32 I don't think the first argument is necessary. Bot
Xianzhu 2015/11/17 00:56:05 The two cases share common code in this class whic
Xianzhu 2015/11/17 18:31:36 'box()' done.
27
28 void invalidatePaintOfScrollControlsIfNeeded(LayoutBox& ownerBox, const Pain tInvalidationState&, const LayoutBoxModelObject& paintInvalidationContainer, Lay outScrollbarPart* scrollCorner, LayoutScrollbarPart* resizer);
chrishtr 2015/11/17 00:44:32 Ditto.
29
30 private:
31 void willRemoveScrollbar(Scrollbar*, ScrollbarOrientation) override { ASSERT _NOT_REACHED(); }
32
33 LayoutRect m_horizontalScrollbarPreviousPaintInvalidationRect;
34 LayoutRect m_verticalScrollbarPreviousPaintInvalidationRect;
35 LayoutRect m_scrollCornerPreviousPaintInvalidationRect;
36 };
37
38 } // namespace blink
39
40 #endif // PaintInvalidationCapableScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698