Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1406133002: Several Site Details / Memory metrics fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_isolate_apps4
Patch Set: thestig's fixes. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/public/browser/web_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index fa61d69065c6f43c33ba0d09b4a951c63be6bb44..01ccda1e2b6b77ae35d68797ed0d84ba4039794d 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -167,22 +167,6 @@ void NotifyCacheOnIO(
cache->OnExternalCacheHit(url, http_method);
}
-// Helper function for retrieving all the sites in a frame tree.
-bool CollectSites(BrowserContext* context,
- std::set<GURL>* sites,
- FrameTreeNode* node) {
- // Record about:blank as a real (process-having) site only if the SiteInstance
- // is unassigned. Do not otherwise depend on the siteinstance's site URL,
- // since its value reflects the current process model, and this function
- // should behave identically across all process models.
- if (node->current_url() == GURL(url::kAboutBlankURL) &&
- node->current_frame_host()->GetSiteInstance()->HasSite()) {
- return true;
- }
- sites->insert(SiteInstance::GetSiteForURL(context, node->current_url()));
- return true;
-}
-
bool FindMatchingProcess(int render_process_id,
bool* did_match_process,
FrameTreeNode* node) {
@@ -1035,14 +1019,6 @@ uint64 WebContentsImpl::GetUploadPosition() const {
return upload_position_;
}
-std::set<GURL> WebContentsImpl::GetSitesInTab() const {
- std::set<GURL> sites;
- frame_tree_.ForEach(base::Bind(&CollectSites,
- base::Unretained(GetBrowserContext()),
- base::Unretained(&sites)));
- return sites;
-}
-
const std::string& WebContentsImpl::GetEncoding() const {
return canonical_encoding_;
}
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/public/browser/web_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698