Issue 140613004: stub fast api calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140613004: stub fast api calls (Closed)

Created:
6 years, 11 months ago by dcarney

Modified:
6 years, 11 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

stub fast api calls R=verwaest@chromium.org, vervaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18847

Patch Set 1 #

Patch Set 2 : ia32 #

Patch Set 3 : arm (partial) #

Patch Set 4 : all working #

Patch Set 5 : rebase #

Total comments: 1

Patch Set 6 : comments #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+543 lines, -431 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 2 3	1 chunk	+114 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 2 3	3 chunks	+21 lines, -22 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1 2 3	6 chunks	+35 lines, -116 lines	0 comments	Download
M	src/code-stubs.h	View	1	2 chunks	+27 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 2 3	1 chunk	+116 lines, -0 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 2 3 4 5	10 chunks	+53 lines, -136 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 2 3 4	1 chunk	+115 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 2 3 4	7 chunks	+51 lines, -146 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

Very nice cleanup! Just one comment on ia32. lgtm if that's fixed. https://codereview.chromium.org/140613004/diff/220001/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc ...

6 years, 11 months ago (2014-01-27 09:48:39 UTC) #2

dcarney

6 years, 11 months ago (2014-01-27 09:58:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #6 manually as r18847 (presubmit successful).

Expand Messages | Collapse Messages