Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 140613002: Cleanup: Replace &LazyInstance::Get() with LazyInstance::Pointer(). (Closed)

Created:
6 years, 11 months ago by Lei Zhang
Modified:
6 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, vandebo (ex-Chrome), felt, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, sadrul, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, vsevik, nona+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, paulirish+reviews_chromium.org, oshima+watch_chromium.org, kalyank, nkostylev+watch_chromium.org, tfarina, ben+ash_chromium.org, yurys, tommycli, davemoore+watch_chromium.org, Greg Billock, pfeldman
Visibility:
Public.

Description

Cleanup: Replace &LazyInstance::Get() with LazyInstance::Pointer(). Also replace *LazyInstance::Pointer() with LazyInstance::Get(). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -70 lines) Patch
M chrome/app/chrome_main_delegate.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/media_player_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/screenlock_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/alarms/alarm_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/api_resource_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/audio/audio_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cast_channel/cast_channel_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cast_channel/cast_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/history/history_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input/input.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/location/location_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/mdns/mdns_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/incognito_connectability.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/processes/processes_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/profile_keyed_api_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/serial/serial_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/serial/serial_event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/socket/socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/socket/tcp_socket.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/socket/udp_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_tcp/tcp_socket_event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_udp/udp_socket_event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/spellcheck/spellcheck_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_windows_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/usb/usb_device_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/form_data_parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_commands_global_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui_override_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/plugin_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/signin/gaia_auth_extension_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
say what you mean, mean what you say
6 years, 11 months ago (2014-01-16 05:39:55 UTC) #1
Lei Zhang
ping
6 years, 11 months ago (2014-01-21 19:53:36 UTC) #2
Nico
lgtm (…but maybe we should have only one of the two methods, then nobody could ...
6 years, 11 months ago (2014-01-21 19:57:17 UTC) #3
Lei Zhang
On 2014/01/21 19:57:17, Nico wrote: > lgtm > > (…but maybe we should have only ...
6 years, 11 months ago (2014-01-21 20:21:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/140613002/1
6 years, 11 months ago (2014-01-21 20:23:25 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-21 22:42:12 UTC) #6
Message was sent while issue was closed.
Change committed as 246142

Powered by Google App Engine
This is Rietveld 408576698