Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1406123010: reland 2: Switch back to field trial. (Closed)

Created:
5 years, 1 month ago by erikchen
Modified:
5 years, 1 month ago
Reviewers:
CC:
chromium-reviews, vmpstr+watch_chromium.org, jam, gavinp+memory_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, loading-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reland 2: "mac: Run A/B experiment on SharedMemory mechanism for resource buffers." The first reland had two mistakes. 1) It tried to turn on Mach-based shared memory on 10.6, which isn't supported. 2) It hit a race condition in AttachmentBrokering code in GPU conformance tests. I submitted two speculative fixes for (2), but haven't been able to reproduce the problem locally, so can't verify that the problem is definitively fixed. Please revert this CL if problems are seen in GPU conformance tests. > The CL changes the default behavior of resource buffer to use a Mach-backed > SharedMemory region. This CL adds a field trial to measure the effect of Mach vs > POSIX backed SharedMemory regions. > > BUG=547261, 466437 > Committed: https://crrev.com/e0e2fd398f3d07c8eebbe662d71a0f9286862476 > Cr-Commit-Position: refs/heads/master@{#356513} BUG=547261, 466437 TBR=mark@chromium.org, isherman@chromium.org, asvitkine@chromium.org, avi@chromium.org Committed: https://crrev.com/91e69f97803b08f998079bd8ec4729b30e346fbb Cr-Commit-Position: refs/heads/master@{#357043}

Patch Set 1 #

Patch Set 2 : Don't use Mach on 10.6. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M base/memory/shared_memory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M base/memory/shared_memory_handle.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 1 4 chunks +53 lines, -0 lines 0 comments Download
M content/browser/loader/resource_buffer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406123010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406123010/20001
5 years, 1 month ago (2015-10-30 00:07:36 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-30 02:04:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406123010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406123010/20001
5 years, 1 month ago (2015-10-30 04:12:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 04:17:04 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/91e69f97803b08f998079bd8ec4729b30e346fbb Cr-Commit-Position: refs/heads/master@{#357043}
5 years, 1 month ago (2015-10-30 04:18:03 UTC) #9
erikchen
5 years, 1 month ago (2015-10-30 21:02:32 UTC) #10
Message was sent while issue was closed.
On 2015/10/30 04:18:03, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/91e69f97803b08f998079bd8ec4729b30e346fbb
> Cr-Commit-Position: refs/heads/master@{#357043}

Reverting this here: https://codereview.chromium.org/1426663006/

Still causing problems on GPU conformance tests:
http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds...
http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds...

Powered by Google App Engine
This is Rietveld 408576698