Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1406113008: [turbofan] Fix inlining with --trace-turbo flag. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix inlining with --trace-turbo flag. This makes sure that --trace-turbo or --turbo-source-positions does not completely disable inlining. The recent introduction of a finalization interface to the reducer borked the SourcePositionWrapper reducer. R=bmeurer@chromium.org Committed: https://crrev.com/f27d2e593fc6af1c047e356742b47e9916aac85f Cr-Commit-Position: refs/heads/master@{#31893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-09 16:17:16 UTC) #1
sigurds
On 2015/11/09 16:17:16, Michael Starzinger wrote: LGTM. Thanks for the quick fix :)
5 years, 1 month ago (2015-11-09 16:22:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406113008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406113008/1
5 years, 1 month ago (2015-11-09 16:42:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 16:44:12 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f27d2e593fc6af1c047e356742b47e9916aac85f Cr-Commit-Position: refs/heads/master@{#31893}
5 years, 1 month ago (2015-11-09 16:44:21 UTC) #8
Benedikt Meurer
5 years, 1 month ago (2015-11-09 16:51:15 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698