Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1406113007: Merge GlobalObject with JSGlobalObject. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Merge GlobalObject with JSGlobalObject. R=jkummerow@chromium.org, mstarzinger@chromium.org Committed: https://crrev.com/1df7377477ade1fc22632c1e82d046bd0a924223 Cr-Commit-Position: refs/heads/master@{#31714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -338 lines) Patch
M src/arm/builtins-arm.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M src/bootstrapper.cc View 14 chunks +19 lines, -19 lines 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/access-builder.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M src/contexts.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/contexts.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/contexts-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug/debug.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/debug/debug-scopes.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/execution.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M src/objects.h View 8 chunks +11 lines, -26 lines 0 comments Download
M src/objects.cc View 13 chunks +15 lines, -15 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/objects-inl.h View 7 chunks +6 lines, -17 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/builtins-ppc.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M src/runtime/runtime-object.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M test/cctest/test-heap.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Yang
Michael, please review src/compiler, src/heap. Jakob, please review the rest.
5 years, 1 month ago (2015-11-02 13:49:30 UTC) #1
Yang
This is possible because JSBuiltinsObject has been removed.
5 years, 1 month ago (2015-11-02 13:49:54 UTC) #2
Michael Starzinger
LGTM on "compiler", "heap" and the object hierarchy, didn't look at the rest.
5 years, 1 month ago (2015-11-02 14:17:39 UTC) #3
Jakob Kummerow
lgtm
5 years, 1 month ago (2015-11-02 14:34:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406113007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406113007/1
5 years, 1 month ago (2015-11-02 14:36:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 14:58:07 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 14:58:34 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1df7377477ade1fc22632c1e82d046bd0a924223
Cr-Commit-Position: refs/heads/master@{#31714}

Powered by Google App Engine
This is Rietveld 408576698