Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1406023021: Fix switch statement in about_flags.cc to support FEATURE_VALUE. (Closed)

Created:
5 years, 1 month ago by Alexei Svitkine (slow)
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix switch statement in about_flags.cc to support FEATURE_VALUE. This was missed by my previous CL (https://codereview.chromium.org/1408783002). BUG=544158 Committed: https://crrev.com/c153c1da7cc9322065fe2477cea081ecd4606410 Cr-Commit-Position: refs/heads/master@{#358375}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Alexei Svitkine (slow)
5 years, 1 month ago (2015-11-06 18:05:05 UTC) #3
Nico
rs-lgtm possible to test this?
5 years, 1 month ago (2015-11-06 18:08:33 UTC) #4
Alexei Svitkine (slow)
I think it should be possible - good idea. Would like to land this in ...
5 years, 1 month ago (2015-11-06 18:46:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406023021/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406023021/20001
5 years, 1 month ago (2015-11-06 18:46:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-11-06 20:27:24 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 20:28:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c153c1da7cc9322065fe2477cea081ecd4606410
Cr-Commit-Position: refs/heads/master@{#358375}

Powered by Google App Engine
This is Rietveld 408576698