Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1406013007: cc: Remove GL_TEXTURE_2D hard-coding (Closed)

Created:
5 years, 1 month ago by ccameron
Modified:
5 years, 1 month ago
Reviewers:
reveman
CC:
cc-bugs_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove GL_TEXTURE_2D hard-coding Change a few instances of hard-coding GL_TEXTURE_2D in VideoResourceUpdater to query the texture target from the resource, and add a helper function to do this query this property. This is neccessary now that the ResourceProvider decides the texture target to use on the client's behalf. BUG=533677 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/1cea3eccdb0bddbac4954ea456c3864f21c05b3a Cr-Commit-Position: refs/heads/master@{#358231}

Patch Set 1 #

Patch Set 2 : Set upstream right #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M cc/resources/resource_provider.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M cc/test/fake_delegated_renderer_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
ccameron
This is the chopped half of the other patch.
5 years, 1 month ago (2015-11-05 22:37:00 UTC) #2
reveman
thanks lgtm
5 years, 1 month ago (2015-11-05 23:07:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406013007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406013007/20001
5 years, 1 month ago (2015-11-06 01:58:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 02:04:47 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 02:05:25 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1cea3eccdb0bddbac4954ea456c3864f21c05b3a
Cr-Commit-Position: refs/heads/master@{#358231}

Powered by Google App Engine
This is Rietveld 408576698