Update Layer Hoisting to store its atlas texture in the resource cache

Update Layer Hoisting to store its atlas texture in the resource cache

BUG=skia:4346
Committed: https://skia.googlesource.com/skia/+/42597bc99f00553825843b5ed41e81b121773368

Committed: https://skia.googlesource.com/skia/+/60029a5397f75aae4bdb994f26bd297edc3e433c

[robertphillips, 2015-11-04 19:55:59]

Description was changed from

==========
Update Layer Hoisting to store its atlas texture in the resource cache

BUG=skia:4346
==========

to

==========
Update Layer Hoisting to store its atlas texture in the resource cache

BUG=skia:4346
==========

[robertphillips, 2015-11-04 19:55:59]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2015-11-04 19:57:37]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-04 19:57:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406013006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406013006/40001

[commit-bot: I haz the power, 2015-11-04 19:58:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 19:58:34]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[robertphillips, 2015-11-04 20:03:16]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-04 20:03:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406013006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406013006/60001

[commit-bot: I haz the power, 2015-11-04 20:04:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 20:04:21]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[robertphillips, 2015-11-04 20:06:45]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-04 20:06:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406013006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406013006/80001

[commit-bot: I haz the power, 2015-11-04 20:18:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 20:18:04]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2015-11-05 15:39:25]

lgtm

https://codereview.chromium.org/1406013006/diff/80001/src/gpu/GrLayerAtlas.cpp
File src/gpu/GrLayerAtlas.cpp (right):

https://codereview.chromium.org/1406013006/diff/80001/src/gpu/GrLayerAtlas.cp...
src/gpu/GrLayerAtlas.cpp:49: GrUniqueKey::Builder builder(result, kDomain, 0);
Can't the key itself be a static?

[robertphillips, 2015-11-05 19:14:22]

https://codereview.chromium.org/1406013006/diff/80001/src/gpu/GrLayerAtlas.cpp
File src/gpu/GrLayerAtlas.cpp (right):

https://codereview.chromium.org/1406013006/diff/80001/src/gpu/GrLayerAtlas.cp...
src/gpu/GrLayerAtlas.cpp:49: GrUniqueKey::Builder builder(result, kDomain, 0);
On 2015/11/05 15:39:25, bsalomon wrote:
> Can't the key itself be a static?

Done.

[robertphillips, 2015-11-05 19:14:29]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 19:14:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406013006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406013006/100001

[bsalomon, 2015-11-05 19:16:43]

lgtm

[commit-bot: I haz the power, 2015-11-05 19:26:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 19:26:32]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-11-06 12:13:58]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-11-06 12:14:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406013006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406013006/100001

[commit-bot: I haz the power, 2015-11-06 12:15:00]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/42597bc99f00553825843b5ed41e81b121773368

[robertphillips, 2015-11-06 13:59:04]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1413483004/ by robertphillips@google.com.

The reason for reverting is: Android.

[robertphillips, 2015-11-09 19:24:15]

Description was changed from

==========
Update Layer Hoisting to store its atlas texture in the resource cache

BUG=skia:4346

Committed:
https://skia.googlesource.com/skia/+/42597bc99f00553825843b5ed41e81b121773368
==========

to

==========
Update Layer Hoisting to store its atlas texture in the resource cache

BUG=skia:4346

Committed:
https://skia.googlesource.com/skia/+/42597bc99f00553825843b5ed41e81b121773368
==========

[robertphillips, 2015-11-09 19:32:57]

More details re the revert: This CL was failing a gpu-config assert on the N5,
N6, N10 and S3. Those are Adreno & Mali GPUs.

FAILURE: ../../../tests/GpuLayerCacheTest.cpp:187	2 == stats.fTotal
FAILURE: ../../../tests/GpuLayerCacheTest.cpp:189	1 == stats.fNumPurgeable
FAILURE: ../../../tests/GpuLayerCacheTest.cpp:226	2 == stats.fTotal
FAILURE: ../../../tests/GpuLayerCacheTest.cpp:228	2 == stats.fNumPurgeable
FAILURE: ../../../tests/GpuLayerCacheTest.cpp:237	2 == stats.fTotal
FAILURE: ../../../tests/GpuLayerCacheTest.cpp:239	1 == stats.fNumPurgeable
FAILURE: ../../../tests/GpuLayerCacheTest.cpp:293	2 == stats.fTotal
FAILURE: ../../../tests/GpuLayerCacheTest.cpp:295	1 == stats.fNumPurgeable
FAILURE: ../../../tests/GpuLayerCacheTest.cpp:314	2 == stats.fTotal
FAILURE: ../../../tests/GpuLayerCacheTest.cpp:315	2 == stats.fNumPurgeable
FAILURE: ../../../tests/GpuLayerCacheTest.cpp:368	2 == stats.fTotal
FAILURE: ../../../tests/GpuLayerCacheTest.cpp:369	1 == stats.fNumPurgeable
FAILURE: ../../../tests/GpuLayerCacheTest.cpp:377	2 == stats.fTotal
FAILURE: ../../../tests/GpuLayerCacheTest.cpp:378	2 == stats.fNumPurgeable

[robertphillips, 2015-11-09 21:31:08]

Scratch texture reuse is disabled for the Adreno & Mali which is why the none-RT
textures were disappearing. The real layer cache always uses RT-style textures
so I have updated the unit test to match.

[robertphillips, 2015-11-09 21:31:15]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-09 21:31:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406013006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406013006/120001

[commit-bot: I haz the power, 2015-11-09 21:42:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-09 21:42:33]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-11-09 21:50:07]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2015-11-09 21:50:07]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1406013006/#ps120001
(title: "Fix Android bug")

[commit-bot: I haz the power, 2015-11-09 21:50:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406013006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406013006/120001

[commit-bot: I haz the power, 2015-11-09 21:51:09]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/60029a5397f75aae4bdb994f26bd297edc3e433c