Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/virtual_memory.cc

Issue 1406013004: Fixes shutdown crashes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/service_isolate.cc ('K') | « runtime/vm/virtual_memory.h ('k') | runtime/vm/virtual_memory_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/virtual_memory.cc
diff --git a/runtime/vm/virtual_memory.cc b/runtime/vm/virtual_memory.cc
index 2f2c1bc855681688a6e8a8e7d3d6af33af7b7c64..af1757cd4947ea7ea6acd9200baa475259843895 100644
--- a/runtime/vm/virtual_memory.cc
+++ b/runtime/vm/virtual_memory.cc
@@ -33,7 +33,9 @@ VirtualMemory* VirtualMemory::ForInstructionsSnapshot(void* pointer,
// Memory for precompilated instructions was allocated by the embedder, so
// create a VirtualMemory without allocating.
MemoryRegion region(pointer, size);
- return new VirtualMemory(region);
+ VirtualMemory* memory = new VirtualMemory(region);
+ memory->dummy_ = true;
rmacnak 2015/10/26 21:38:15 How about embedder_allocated_ ?
zra 2015/10/26 21:49:58 Done.
+ return memory;
}
} // namespace dart
« runtime/vm/service_isolate.cc ('K') | « runtime/vm/virtual_memory.h ('k') | runtime/vm/virtual_memory_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698