runtime/vm/virtual_memory_macos.cc - Issue 1406013004: Fixes shutdown crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/virtual_memory_macos.cc

Issue 1406013004: Fixes shutdown crashes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/virtual_memory_macos.cc

diff --git a/runtime/vm/virtual_memory_macos.cc b/runtime/vm/virtual_memory_macos.cc

index 331ac4bf7b7afe4f0e483b0460650d8b68b7f625..42e1c71e0430d1616a5a9a7f9dcab36c65ac90df 100644

--- a/runtime/vm/virtual_memory_macos.cc

+++ b/runtime/vm/virtual_memory_macos.cc

@@ -53,7 +53,9 @@ static void unmap(void* address, intptr_t size) {

VirtualMemory::~VirtualMemory() {

- unmap(address(), reserved_size_);

+ if (!dummy()) {

+ unmap(address(), reserved_size_);

+ }

}