Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2786)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui.h

Issue 1406013003: [Presentation API / Media Router] Clean up default pres URL logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed mfoltz's comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_ui.h
diff --git a/chrome/browser/ui/webui/media_router/media_router_ui.h b/chrome/browser/ui/webui/media_router/media_router_ui.h
index 3d7859f49b6f38cd254d0cb1ab151d15100703db..327e079604f5590d09f6140258727287aa1ee024 100644
--- a/chrome/browser/ui/webui/media_router/media_router_ui.h
+++ b/chrome/browser/ui/webui/media_router/media_router_ui.h
@@ -41,10 +41,10 @@ class MediaSinksObserver;
class CreatePresentationSessionRequest;
// Implements the chrome://media-router user interface.
-class MediaRouterUI
- : public ConstrainedWebDialogUI,
- public QueryResultManager::Observer,
- public PresentationServiceDelegateImpl::DefaultMediaSourceObserver {
+class MediaRouterUI : public ConstrainedWebDialogUI,
+ public QueryResultManager::Observer,
+ public PresentationServiceDelegateImpl::
+ DefaultPresentationRequestObserver {
public:
// |web_ui| owns this object and is used to initialize the base class.
explicit MediaRouterUI(content::WebUI* web_ui);
@@ -163,20 +163,12 @@ class MediaRouterUI
// Creates and sends an issue if route creation times out.
void RouteCreationTimeout();
- // Sets the source host name to be displayed in the UI.
- // Gets cast modes from |query_result_manager_| and forwards it to UI.
- // One of the Init* functions must have been called before.
- void UpdateSourceHostAndCastModes(const GURL& frame_url);
+ // Initializes the dialog with mirroring sources derived from |initiator|.
+ void InitCommon(content::WebContents* initiator);
- // Initializes the dialog with mirroring sources derived from |initiator|,
- // and optional |default_source| and |default_frame_url| if any.
- void InitCommon(content::WebContents* initiator,
- const MediaSource& default_source,
- const GURL& default_frame_url);
-
- // PresentationServiceDelegateImpl::DefaultMediaSourceObserver
- void OnDefaultMediaSourceChanged(const MediaSource& source,
- const GURL& frame_url) override;
+ // PresentationServiceDelegateImpl::DefaultPresentationObserver
+ void OnDefaultPresentationChanged(
+ const PresentationRequest* presentation_request) override;
// Owned by the |web_ui| passed in the ctor, and guaranteed to be deleted
// only after it has deleted |this|.
@@ -208,7 +200,11 @@ class MediaRouterUI
// If set, then the result of the next presentation route request will
// be handled by this object.
- scoped_ptr<CreatePresentationSessionRequest> presentation_request_;
+ scoped_ptr<CreatePresentationSessionRequest> create_session_request_;
+
+ // Set to the presentation request corresponding to the presentation cast
+ // mode, if supported. Otherwise set to nullptr.
+ scoped_ptr<PresentationRequest> presentation_request_;
// It's possible for PresentationServiceDelegateImpl to be destroyed before
// this class.

Powered by Google App Engine
This is Rietveld 408576698