Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1804)

Unified Diff: chrome/browser/media/router/create_presentation_session_request.h

Issue 1406013003: [Presentation API / Media Router] Clean up default pres URL logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed mfoltz's comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/create_presentation_session_request.h
diff --git a/chrome/browser/media/router/create_presentation_session_request.h b/chrome/browser/media/router/create_presentation_session_request.h
index 9cebcb9aabc8a8d0644db629eea410567e462026..3d751397cc4e97764816f1545c23d082b22180f8 100644
--- a/chrome/browser/media/router/create_presentation_session_request.h
+++ b/chrome/browser/media/router/create_presentation_session_request.h
@@ -9,6 +9,8 @@
#include "chrome/browser/media/router/media_route.h"
#include "chrome/browser/media/router/media_source.h"
+#include "chrome/browser/media/router/presentation_request.h"
+#include "chrome/browser/media/router/render_frame_host_id.h"
#include "content/public/browser/presentation_service_delegate.h"
#include "url/gurl.h"
@@ -31,22 +33,23 @@ class CreatePresentationSessionRequest {
base::Callback<void(const content::PresentationSessionInfo&,
const MediaRoute::Id&)>;
using PresentationSessionErrorCallback =
- content::PresentationServiceDelegate::PresentationSessionErrorCallback;
-
+ content::PresentationSessionErrorCallback;
// |presentation_url|: The presentation URL of the request. Must be a valid
// URL.
// |frame_url|: The URL of the frame that initiated the presentation request.
// |success_cb|: Callback to invoke when the request succeeds. Must be valid.
// |erorr_cb|: Callback to invoke when the request fails. Must be valid.
CreatePresentationSessionRequest(
+ const RenderFrameHostId& render_frame_host_id,
const std::string& presentation_url,
const GURL& frame_url,
const PresentationSessionSuccessCallback& success_cb,
const PresentationSessionErrorCallback& error_cb);
~CreatePresentationSessionRequest();
- const MediaSource& media_source() const { return media_source_; }
- const GURL& frame_url() const { return frame_url_; }
+ const PresentationRequest& presentation_request() const {
+ return presentation_request_;
+ }
// Invokes |success_cb_| or |error_cb_| with the given arguments.
// These functions can only be invoked once per instance. It is an error
@@ -63,8 +66,7 @@ class CreatePresentationSessionRequest {
const std::string& error);
private:
- const MediaSource media_source_;
- const GURL frame_url_;
+ const PresentationRequest presentation_request_;
PresentationSessionSuccessCallback success_cb_;
PresentationSessionErrorCallback error_cb_;
bool cb_invoked_;

Powered by Google App Engine
This is Rietveld 408576698