Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Side by Side Diff: chrome/browser/media/router/create_presentation_session_request.h

Issue 1406013003: [Presentation API / Media Router] Clean up default pres URL logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments #20, #22 Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_MEDIA_ROUTER_CREATE_PRESENTATION_SESSION_REQUEST_H_ 5 #ifndef CHROME_BROWSER_MEDIA_ROUTER_CREATE_PRESENTATION_SESSION_REQUEST_H_
6 #define CHROME_BROWSER_MEDIA_ROUTER_CREATE_PRESENTATION_SESSION_REQUEST_H_ 6 #define CHROME_BROWSER_MEDIA_ROUTER_CREATE_PRESENTATION_SESSION_REQUEST_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "chrome/browser/media/router/media_route.h" 10 #include "chrome/browser/media/router/media_route.h"
11 #include "chrome/browser/media/router/media_source.h" 11 #include "chrome/browser/media/router/media_source.h"
12 #include "chrome/browser/media/router/presentation_request.h"
13 #include "chrome/browser/media/router/render_frame_host_id.h"
12 #include "content/public/browser/presentation_service_delegate.h" 14 #include "content/public/browser/presentation_service_delegate.h"
13 #include "url/gurl.h" 15 #include "url/gurl.h"
14 16
15 namespace content { 17 namespace content {
16 struct PresentationError; 18 struct PresentationError;
17 struct PresentationSessionInfo; 19 struct PresentationSessionInfo;
18 } // namespace content 20 } // namespace content
19 21
20 namespace media_router { 22 namespace media_router {
21 23
22 // Holds parameters for creating a presentation session. 24 // Holds parameters for creating a presentation session.
23 // A request object is created by presentation_service_delegate_impl when it 25 // A request object is created by presentation_service_delegate_impl when it
24 // gets create-session request. The object is then passed to and owned by the 26 // gets create-session request. The object is then passed to and owned by the
25 // MediaRouterUI. |success_cb| will be invoked when create-session 27 // MediaRouterUI. |success_cb| will be invoked when create-session
26 // succeeds, or |error_cb| will be invoked when create-session fails or 28 // succeeds, or |error_cb| will be invoked when create-session fails or
27 // the UI closes. 29 // the UI closes.
28 class CreatePresentationSessionRequest { 30 class CreatePresentationSessionRequest {
mark a. foltz 2015/11/09 18:33:35 This might be better called "CreatePresentationCon
imcheng 2015/11/10 18:49:13 Done.
29 public: 31 public:
30 using PresentationSessionSuccessCallback = 32 using PresentationSessionSuccessCallback =
31 base::Callback<void(const content::PresentationSessionInfo&, 33 base::Callback<void(const content::PresentationSessionInfo&,
32 const MediaRoute::Id&)>; 34 const MediaRoute::Id&)>;
33 using PresentationSessionErrorCallback = 35 using PresentationSessionErrorCallback =
34 content::PresentationServiceDelegate::PresentationSessionErrorCallback; 36 content::PresentationSessionErrorCallback;
35
36 // |presentation_url|: The presentation URL of the request. Must be a valid 37 // |presentation_url|: The presentation URL of the request. Must be a valid
37 // URL. 38 // URL.
38 // |frame_url|: The URL of the frame that initiated the presentation request. 39 // |frame_url|: The URL of the frame that initiated the presentation request.
39 // |success_cb|: Callback to invoke when the request succeeds. Must be valid. 40 // |success_cb|: Callback to invoke when the request succeeds. Must be valid.
40 // |erorr_cb|: Callback to invoke when the request fails. Must be valid. 41 // |erorr_cb|: Callback to invoke when the request fails. Must be valid.
41 CreatePresentationSessionRequest( 42 CreatePresentationSessionRequest(
43 const RenderFrameHostId& render_frame_host_id,
42 const std::string& presentation_url, 44 const std::string& presentation_url,
43 const GURL& frame_url, 45 const GURL& frame_url,
44 const PresentationSessionSuccessCallback& success_cb, 46 const PresentationSessionSuccessCallback& success_cb,
45 const PresentationSessionErrorCallback& error_cb); 47 const PresentationSessionErrorCallback& error_cb);
46 ~CreatePresentationSessionRequest(); 48 ~CreatePresentationSessionRequest();
47 49
48 const MediaSource& media_source() const { return media_source_; } 50 const PresentationRequest& presentation_request() const {
49 const GURL& frame_url() const { return frame_url_; } 51 return presentation_request_;
52 }
50 53
51 // Invokes |success_cb_| or |error_cb_| with the given arguments. 54 // Invokes |success_cb_| or |error_cb_| with the given arguments.
52 // These functions can only be invoked once per instance. It is an error 55 // These functions can only be invoked once per instance. It is an error
53 // to invoke these functions more than once. 56 // to invoke these functions more than once.
54 void InvokeSuccessCallback(const std::string& presentation_id, 57 void InvokeSuccessCallback(const std::string& presentation_id,
55 const MediaRoute::Id& route_id); 58 const MediaRoute::Id& route_id);
56 void InvokeErrorCallback(const content::PresentationError& error); 59 void InvokeErrorCallback(const content::PresentationError& error);
57 60
58 // Handle route creation/joining response by invoking the right callback. 61 // Handle route creation/joining response by invoking the right callback.
59 static void HandleRouteResponse( 62 static void HandleRouteResponse(
60 scoped_ptr<CreatePresentationSessionRequest> presentation_request, 63 scoped_ptr<CreatePresentationSessionRequest> presentation_request,
61 const MediaRoute* route, 64 const MediaRoute* route,
62 const std::string& presentation_id, 65 const std::string& presentation_id,
63 const std::string& error); 66 const std::string& error);
64 67
65 private: 68 private:
66 const MediaSource media_source_; 69 const PresentationRequest presentation_request_;
67 const GURL frame_url_;
68 PresentationSessionSuccessCallback success_cb_; 70 PresentationSessionSuccessCallback success_cb_;
69 PresentationSessionErrorCallback error_cb_; 71 PresentationSessionErrorCallback error_cb_;
70 bool cb_invoked_; 72 bool cb_invoked_;
71 73
72 DISALLOW_COPY_AND_ASSIGN(CreatePresentationSessionRequest); 74 DISALLOW_COPY_AND_ASSIGN(CreatePresentationSessionRequest);
73 }; 75 };
74 76
75 } // namespace media_router 77 } // namespace media_router
76 78
77 #endif // CHROME_BROWSER_MEDIA_ROUTER_CREATE_PRESENTATION_SESSION_REQUEST_H_ 79 #endif // CHROME_BROWSER_MEDIA_ROUTER_CREATE_PRESENTATION_SESSION_REQUEST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698