chrome/browser/media/router/render_frame_host_id.h - Issue 1406013003: [Presentation API / Media Router] Clean up default pres URL logic.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/media/router/render_frame_host_id.h

Issue 1406013003: [Presentation API / Media Router] Clean up default pres URL logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed mfoltz's comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/media/router/presentation_service_delegate_impl.h ('K') | « chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc ('k') | chrome/browser/ui/webui/media_router/media_router_ui.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_MEDIA_ROUTER_RENDER_FRAME_HOST_ID_H_

	6 #define CHROME_BROWSER_MEDIA_ROUTER_RENDER_FRAME_HOST_ID_H_

	7

	8 #include <utility>

	9

	10 namespace media_router {

	11

	12 using RenderFrameHostId = std::pair<int, int>;
	mlamouri (slow - plz ping) 2015/10/27 18:42:51 I would prefer if you could use render_frame_id an I would prefer if you could use render_frame_id and render_process_id instead of creating this for consistency with the current code. This said, I agree that we need such type. imcheng 2015/10/27 20:50:14 There are existing places (PresentationServiceDele Show quoted text On 2015/10/27 18:42:51, Mounir Lamouri wrote: > I would prefer if you could use render_frame_id and render_process_id instead of > creating this for consistency with the current code. This said, I agree that we > need such type. There are existing places (PresentationServiceDelegateImpl) where it is used and is also used as a key in maps. So rather than std::map<std::pair<int, int>, Foo>, std::map<RenderFrameHostId, Foo> provides more information and is also less wordy.
	13

	14 } // namespace media_router

	15

	16 #endif // CHROME_BROWSER_MEDIA_ROUTER_RENDER_FRAME_HOST_ID_H_

OLD	NEW