Index: cc/output/gl_renderer_pixeltest.cc |
diff --git a/cc/output/gl_renderer_pixeltest.cc b/cc/output/gl_renderer_pixeltest.cc |
index 064b78bf27a2980d47aa8ca1256a81c7ff463f41..35e990992f84edb22937beed131b7bedd07dca39 100644 |
--- a/cc/output/gl_renderer_pixeltest.cc |
+++ b/cc/output/gl_renderer_pixeltest.cc |
@@ -92,14 +92,13 @@ TEST_F(GLRendererPixelTest, SimpleGreenRect) { |
RenderPassList pass_list; |
pass_list.push_back(pass.Pass()); |
- renderer_->DrawFrame(&pass_list); |
- |
- EXPECT_TRUE(PixelsMatchReference( |
+ EXPECT_TRUE(RunPixelTest( |
+ &pass_list, |
base::FilePath(FILE_PATH_LITERAL("green.png")), |
ExactPixelComparator(true))); |
} |
-TEST_F(GLRendererPixelTest, fastPassColorFilterAlpha) { |
+TEST_F(GLRendererPixelTest, FastPassColorFilterAlpha) { |
gfx::Rect viewport_rect(device_viewport_size_); |
RenderPass::Id root_pass_id(1, 1); |
@@ -168,7 +167,8 @@ TEST_F(GLRendererPixelTest, fastPassColorFilterAlpha) { |
skia::RefPtr<SkImageFilter> filter = |
skia::AdoptRef(SkColorFilterImageFilter::Create(colorFilter.get(), NULL)); |
- scoped_ptr<RenderPassDrawQuad> render_pass_quad = RenderPassDrawQuad::Create(); |
+ scoped_ptr<RenderPassDrawQuad> render_pass_quad = |
+ RenderPassDrawQuad::Create(); |
render_pass_quad->SetNew(pass_shared_state.get(), |
pass_rect, |
child_pass_id, |
@@ -186,16 +186,13 @@ TEST_F(GLRendererPixelTest, fastPassColorFilterAlpha) { |
pass_list.push_back(child_pass.Pass()); |
pass_list.push_back(root_pass.Pass()); |
- renderer_->SetEnlargePassTextureAmountForTesting(gfx::Vector2d(50, 75)); |
- renderer_->DecideRenderPassAllocationsForFrame(pass_list); |
- renderer_->DrawFrame(&pass_list); |
- |
- EXPECT_TRUE(PixelsMatchReference( |
+ EXPECT_TRUE(RunPixelTest( |
+ &pass_list, |
base::FilePath(FILE_PATH_LITERAL("blue_yellow_alpha.png")), |
ExactPixelComparator(false))); |
} |
-TEST_F(GLRendererPixelTest, fastPassColorFilterAlphaTranslation) { |
+TEST_F(GLRendererPixelTest, FastPassColorFilterAlphaTranslation) { |
gfx::Rect viewport_rect(device_viewport_size_); |
RenderPass::Id root_pass_id(1, 1); |
@@ -286,11 +283,8 @@ TEST_F(GLRendererPixelTest, fastPassColorFilterAlphaTranslation) { |
pass_list.push_back(child_pass.Pass()); |
pass_list.push_back(root_pass.Pass()); |
- renderer_->SetEnlargePassTextureAmountForTesting(gfx::Vector2d(50, 75)); |
- renderer_->DecideRenderPassAllocationsForFrame(pass_list); |
- renderer_->DrawFrame(&pass_list); |
- |
- EXPECT_TRUE(PixelsMatchReference( |
+ EXPECT_TRUE(RunPixelTest( |
+ &pass_list, |
base::FilePath(FILE_PATH_LITERAL("blue_yellow_alpha_translate.png")), |
ExactPixelComparator(false))); |
} |
@@ -342,17 +336,16 @@ TEST_F(GLRendererPixelTest, RenderPassChangesSize) { |
pass_list.push_back(root_pass.Pass()); |
renderer_->SetEnlargePassTextureAmountForTesting(gfx::Vector2d(50, 75)); |
- renderer_->DecideRenderPassAllocationsForFrame(pass_list); |
- renderer_->DrawFrame(&pass_list); |
- EXPECT_TRUE(PixelsMatchReference( |
+ EXPECT_TRUE(RunPixelTest( |
+ &pass_list, |
base::FilePath(FILE_PATH_LITERAL("blue_yellow.png")), |
ExactPixelComparator(true))); |
} |
class GLRendererPixelTestWithBackgroundFilter : public GLRendererPixelTest { |
protected: |
- void DrawFrame() { |
+ void SetUpRenderPassList() { |
gfx::Rect device_viewport_rect(device_viewport_size_); |
RenderPass::Id root_id(1, 1); |
@@ -452,14 +445,11 @@ class GLRendererPixelTestWithBackgroundFilter : public GLRendererPixelTest { |
root_pass->quad_list.push_back(background_quad.PassAs<DrawQuad>()); |
root_pass->shared_quad_state_list.push_back(shared_state.Pass()); |
- RenderPassList pass_list; |
- pass_list.push_back(filter_pass.Pass()); |
- pass_list.push_back(root_pass.Pass()); |
- |
- renderer_->DecideRenderPassAllocationsForFrame(pass_list); |
- renderer_->DrawFrame(&pass_list); |
+ pass_list_.push_back(filter_pass.Pass()); |
+ pass_list_.push_back(root_pass.Pass()); |
} |
+ RenderPassList pass_list_; |
WebKit::WebFilterOperations background_filters_; |
gfx::Transform filter_pass_to_target_transform_; |
gfx::Rect filter_pass_content_rect_; |
@@ -472,8 +462,9 @@ TEST_F(GLRendererPixelTestWithBackgroundFilter, InvertFilter) { |
filter_pass_content_rect_ = gfx::Rect(device_viewport_size_); |
filter_pass_content_rect_.Inset(12, 14, 16, 18); |
- DrawFrame(); |
- EXPECT_TRUE(PixelsMatchReference( |
+ SetUpRenderPassList(); |
+ EXPECT_TRUE(RunPixelTest( |
+ &pass_list_, |
base::FilePath(FILE_PATH_LITERAL("background_filter.png")), |
ExactPixelComparator(true))); |
} |
@@ -482,9 +473,7 @@ TEST_F(GLRendererPixelTest, AntiAliasing) { |
gfx::Rect rect(0, 0, 200, 200); |
RenderPass::Id id(1, 1); |
- gfx::Transform transform_to_root; |
- scoped_ptr<RenderPass> pass = |
- CreateTestRenderPass(id, rect, transform_to_root); |
+ scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect); |
gfx::Transform red_content_to_target_transform; |
red_content_to_target_transform.Rotate(10); |
@@ -518,9 +507,8 @@ TEST_F(GLRendererPixelTest, AntiAliasing) { |
RenderPassList pass_list; |
pass_list.push_back(pass.Pass()); |
- renderer_->DrawFrame(&pass_list); |
- |
- EXPECT_TRUE(PixelsMatchReference( |
+ EXPECT_TRUE(RunPixelTest( |
+ &pass_list, |
base::FilePath(FILE_PATH_LITERAL("anti_aliasing.png")), |
ExactPixelComparator(true))); |
} |