components/autofill/browser/autofill_metrics.h - Issue 14060013: Add UMA stats to track whitelist download latency.

Unified Diff: components/autofill/browser/autofill_metrics.h

Issue 14060013: Add UMA stats to track whitelist download latency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/browser/autocheckout/whitelist_manager_unittest.cc ('K') | « components/autofill/browser/autocheckout/whitelist_manager_unittest.cc ('k') | components/autofill/browser/autofill_metrics.cc » ('j') | components/autofill/browser/autofill_metrics.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/browser/autofill_metrics.h

diff --git a/components/autofill/browser/autofill_metrics.h b/components/autofill/browser/autofill_metrics.h

index 2f9abd03507ba1ea2b0c3ecb654929ebda093b35..ce11316267bf07859c5c70f25b56addbad11ab70 100644

--- a/components/autofill/browser/autofill_metrics.h

+++ b/components/autofill/browser/autofill_metrics.h

@@ -350,6 +350,14 @@ class AutofillMetrics {

NUM_WALLET_REQUIRED_ACTIONS

};

+ // The success or failure of downloading Autocheckout whitelist file.

+ enum WhitelistDownloadStatus {

ahutter 2013/04/16 17:56:54 Probably want to throw Autocheckout on the front o

benquan 2013/04/17 01:51:30 Done.

+ // The download was failed.

ahutter 2013/04/16 17:56:54 The download failed.

Ilya Sherman 2013/04/17 00:18:01 nit: This comment is almost verbatim identical to

benquan 2013/04/17 01:51:30 Done.

benquan 2013/04/17 05:48:18 Done.

+ WHITELIST_DOWNLOAD_FAILED,

ahutter 2013/04/16 17:56:54 Ditto about AUTOCHECKOUT

benquan 2013/04/17 01:51:30 Done.

+ // The download was succeeded.

ahutter 2013/04/16 17:56:54 The download was successful.

benquan 2013/04/17 01:51:30 Done.

+ WHITELIST_DOWNLOAD_SUCCEEDED,

ahutter 2013/04/16 17:56:54 ditto about AUTOCHECKOUT.

benquan 2013/04/17 01:51:30 Done.

+ };

AutofillMetrics();

virtual ~AutofillMetrics();

@@ -435,6 +443,9 @@ class AutofillMetrics {

const base::TimeDelta& duration,

AutocheckoutCompletionStatus status) const;

+ virtual void LogAutocheckoutWhitelistDownloadDuration(

ahutter 2013/04/16 17:56:54 Docs.

benquan 2013/04/17 01:51:30 Done.

+ const base::TimeDelta& duration, WhitelistDownloadStatus status) const;

Ilya Sherman 2013/04/17 00:18:01 nit: One parameter per line, please, if they have

benquan 2013/04/17 01:51:30 Done.

// This should be called when a form that has been Autofilled is submitted.

// |duration| should be the time elapsed between form load and submission.

virtual void LogFormFillDurationFromLoadWithAutofill(