Add UMA stats to track whitelist download latency.

components/autofill/browser/autocheckout/whitelist_manager.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_BROWSER_AUTOCHECKOUT_WHITELIST_MANAGER_H_
 #define COMPONENTS_AUTOFILL_BROWSER_AUTOCHECKOUT_WHITELIST_MANAGER_H_
 
 #include <string>
 #include <vector>
 
 #include "base/timer.h"
+#include "components/autofill/browser/autofill_metrics.h"
 #include "net/url_request/url_fetcher_delegate.h"
 
 class GURL;
 
 namespace content {
 class BrowserContext;
 }
 
 namespace net {
 class URLFetcher;
@@ skipping 20 matching lines @@
   std::string GetMatchedURLPrefix(const GURL& url) const;
 
  protected:
   // Schedules a future call to TriggerDownload if one isn't already pending.
   virtual void ScheduleDownload(size_t interval_seconds);
 
   // Start the download timer. It is called by ScheduleDownload(), and exposed
   // as a separate method for mocking out in tests.
   virtual void StartDownloadTimer(size_t interval_seconds);
 
+  // Returns the |AutofillMetrics| instance that should be used for logging

[ahutter, 2013/04/16 17:56:54]

Take a look at autocheckout_manager.h. Might be good to be consistent with how
that deals with the metrics logger.

[benquan, 2013/04/17 01:51:30]

I was following autocheckout_request_manager.h and
autofill_dialog_controller_impl.h. I like this better because it does not
require me add setter which is only for tests, and I don't need to worry about
NULL pointers and object ownership etc.

+  // Autocheckout whitelist file downloading.
+  virtual const AutofillMetrics& GetMetricLogger() const {
+    return metrics_logger_;

[Ilya Sherman, 2013/04/17 00:18:01]

nit: virtual method implementations belong in the .cc file

[benquan, 2013/04/17 01:51:30]

Done.

+  }
+
   // Timer callback indicating it's time to download whitelist from server.
   void TriggerDownload();
 
   // Used by tests only.
   void StopDownloadTimer();
 
   const std::vector<std::string>& url_prefixes() const {
     return url_prefixes_;
   }
 
@@ skipping 14 matching lines @@
 
   // The context for the request.
   net::URLRequestContextGetter* context_getter_;  // WEAK
 
   // State of the kEnableExperimentalFormFilling flag.
   const bool experimental_form_filling_enabled_;
 
   // State of the kBypassAutocheckoutWhitelist flag.
   const bool bypass_autocheckout_whitelist_;
 
+  // Metrics Logging stuff.

[ahutter, 2013/04/16 17:56:54]

"Logger for UMA metrics" or something like that.

[benquan, 2013/04/17 01:51:30]

Done.

+  AutofillMetrics metrics_logger_;

[ahutter, 2013/04/16 17:56:54]

new line after this.

[benquan, 2013/04/17 01:51:30]

Done.

+  // When the whitelist download started. Used to track download latency.
+  base::Time request_started_timestamp_;
+
   // The request object.
   scoped_ptr<net::URLFetcher> request_;
 
   DISALLOW_COPY_AND_ASSIGN(WhitelistManager);
 };
 
 }  // namespace autocheckout
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_BROWSER_AUTOCHECKOUT_WHITELIST_MANAGER_H_