Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1405993009: Allow constant heap accesses in asm typer. (Closed)

Created:
5 years, 1 month ago by bradn
Modified:
5 years, 1 month ago
Reviewers:
titzer, aseemgarg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow constant heap accesses in asm typer. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Committed: https://crrev.com/318bcbee31e031fe3a24256f935fb9dec7ff4ea6 Cr-Commit-Position: refs/heads/master@{#31908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -17 lines) Patch
M src/typing-asm.cc View 1 chunk +23 lines, -17 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
bradn
5 years, 1 month ago (2015-11-10 00:46:20 UTC) #1
titzer
lgtm
5 years, 1 month ago (2015-11-10 01:02:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405993009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405993009/1
5 years, 1 month ago (2015-11-10 01:58:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 01:59:49 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 02:00:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/318bcbee31e031fe3a24256f935fb9dec7ff4ea6
Cr-Commit-Position: refs/heads/master@{#31908}

Powered by Google App Engine
This is Rietveld 408576698