third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html - Issue 1405993008: compositor-worker: plumb element id and mutable properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html

Issue 1405993008: compositor-worker: plumb element id and mutable properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/layers/layer_unittest.cc ('k') | third_party/WebKit/LayoutTests/media/track/track-word-breaking.html » ('j') | third_party/WebKit/Source/core/dom/CompositorProxy.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html

diff --git a/third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html b/third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html

index c249bbfc5580b975cbe45bab78a1cc2f45116472..1ce75e6cebbb916378c358b9db63ff41faf4125b 100644

--- a/third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html

+++ b/third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html

@@ -1,5 +1,15 @@

+ <script>

+ if (window.internals)

+ {

+ // This should not be necessary, but due to crbug.com/372245 style

+ // gets dirtied during layout in LayoutTextTrackContainer which

+ // causes assertions to fail when Document::scrollingElement is

+ // queried during compositing update (a valid request).

+ window.internals.settings.setCompositorWorkerEnabled(false);

esprehn 2015/12/02 03:28:48 sigh, this is really awful. We need to fix the bus

Ian Vollick 2015/12/03 17:54:43 Agreed.

+ }

+ </script>