Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3827)

Unified Diff: chrome/installer/util/shell_util.h

Issue 1405993006: Revert of Change shortcut install location to non-subdir. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/util/shell_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/shell_util.h
diff --git a/chrome/installer/util/shell_util.h b/chrome/installer/util/shell_util.h
index 1c34c5d36d2bd9ae723dfa441c6a708dc6fcb9ff..f13e2bb40d11ff6c3659d23a0a81e6b53b85f621 100644
--- a/chrome/installer/util/shell_util.h
+++ b/chrome/installer/util/shell_util.h
@@ -54,9 +54,9 @@
SHORTCUT_LOCATION_DESKTOP = SHORTCUT_LOCATION_FIRST,
SHORTCUT_LOCATION_QUICK_LAUNCH,
SHORTCUT_LOCATION_START_MENU_ROOT,
- SHORTCUT_LOCATION_START_MENU_CHROME_DIR_DEPRECATED, // now placed in root
+ SHORTCUT_LOCATION_START_MENU_CHROME_DIR,
SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR,
- SHORTCUT_LOCATION_TASKBAR_PINS, // base::win::VERSION_WIN7 +
+ SHORTCUT_LOCATION_TASKBAR_PINS, // base::win::VERSION_WIN7 +
SHORTCUT_LOCATION_APP_SHORTCUTS, // base::win::VERSION_WIN8 +
NUM_SHORTCUT_LOCATIONS
};
@@ -311,24 +311,16 @@
// Returns true if the current Windows version supports the presence of
// shortcuts at |location|.
- static bool ShortcutLocationIsSupported(ShortcutLocation location);
+ static bool ShortcutLocationIsSupported(ShellUtil::ShortcutLocation location);
// Sets |path| to the path for a shortcut at the |location| desired for the
// given |level| (CURRENT_USER for per-user path and SYSTEM_LEVEL for
// all-users path).
// Returns false on failure.
- static bool GetShortcutPath(ShortcutLocation location,
+ static bool GetShortcutPath(ShellUtil::ShortcutLocation location,
BrowserDistribution* dist,
ShellChange level,
base::FilePath* path);
-
- // Move an existing shortcut from |old_location| to |new_location| for the
- // set |shortcut_level|. If the folder containing |old_location| is then
- // empty, it will be removed.
- static bool MoveExistingShortcut(ShortcutLocation old_location,
- ShortcutLocation new_location,
- BrowserDistribution* dist,
- const ShortcutProperties& properties);
// Updates shortcut in |location| (or creates it if |options| specify
// SHELL_SHORTCUT_CREATE_ALWAYS).
@@ -340,10 +332,10 @@
// SHORTCUT_LOCATION_START_MENU_CHROME_DIR, or
// SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR.
static bool CreateOrUpdateShortcut(
- ShortcutLocation location,
+ ShellUtil::ShortcutLocation location,
BrowserDistribution* dist,
- const ShortcutProperties& properties,
- ShortcutOperation operation);
+ const ShellUtil::ShortcutProperties& properties,
+ ShellUtil::ShortcutOperation operation);
// Returns the string "|icon_path|,|icon_index|" (see, for example,
// http://msdn.microsoft.com/library/windows/desktop/dd391573.aspx).
@@ -551,7 +543,7 @@
// If |location| is a Chrome-specific folder, it will be deleted as well.
// Returns true if all shortcuts pointing to |target_exe| are successfully
// deleted, including the case where no such shortcuts are found.
- static bool RemoveShortcuts(ShortcutLocation location,
+ static bool RemoveShortcuts(ShellUtil::ShortcutLocation location,
BrowserDistribution* dist,
ShellChange level,
const base::FilePath& target_exe);
@@ -565,7 +557,7 @@
// Returns true if all updates to matching shortcuts are successful, including
// the vacuous case where no matching shortcuts are found.
static bool RetargetShortcutsWithArgs(
- ShortcutLocation location,
+ ShellUtil::ShortcutLocation location,
BrowserDistribution* dist,
ShellChange level,
const base::FilePath& old_target_exe,
@@ -578,7 +570,7 @@
// those shortcuts. This method will abort and return false if |cancel| is
// non-NULL and gets set at any point during this call.
static bool ShortcutListMaybeRemoveUnknownArgs(
- ShortcutLocation location,
+ ShellUtil::ShortcutLocation location,
BrowserDistribution* dist,
ShellChange level,
const base::FilePath& chrome_exe,
« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/util/shell_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698