Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1405963012: Remove [TreatNullAs=NullString] from attributes on CanvasRenderingContext2D (Closed)

Created:
5 years, 1 month ago by tanay.c
Modified:
5 years, 1 month ago
Reviewers:
philipj_slow, Mike West
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove [TreatNullAs=NullString] from attributes on CanvasRenderingContext2D This change does not modify the current behavior for the attributes (default values are assigned for null assignment): CanvasRenderingContext2D.globalCompositeOperation = null => ' source-over ' CanvasRenderingContext2D.shadowColor = null => 'rgba(0,0,0,0)' CanvasRenderingContext2D.lineCap = null => 'butt' CanvasRenderingContext2D.lineJoin = null => 'miter' Behavior is consistent with Firefox Nightly. BUG=497307 Committed: https://crrev.com/12c12ffc8aa18319bb57c209ddfa7eb58cb56caa Cr-Commit-Position: refs/heads/master@{#358021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
tanay.c
PTAL
5 years, 1 month ago (2015-11-05 08:51:53 UTC) #2
philipj_slow
lgtm I've confirmed that the setters return and do nothing if the value isn't valid, ...
5 years, 1 month ago (2015-11-05 09:15:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405963012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405963012/1
5 years, 1 month ago (2015-11-05 09:15:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 10:18:02 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 10:18:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12c12ffc8aa18319bb57c209ddfa7eb58cb56caa
Cr-Commit-Position: refs/heads/master@{#358021}

Powered by Google App Engine
This is Rietveld 408576698