Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1572)

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 1405963005: Create `loadLibrary` function element eagerly. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/task/dart.dart
diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart
index b87f7763338f8bf316b1c20dcced7f3d227295d5..5bf577238633d6b15831c5208cb6e6c319fcfcee 100644
--- a/pkg/analyzer/lib/src/task/dart.dart
+++ b/pkg/analyzer/lib/src/task/dart.dart
@@ -3783,6 +3783,11 @@ class ResolveLibraryTypeNamesTask extends SourceBasedAnalysisTask {
static const String LIBRARY_INPUT = 'LIBRARY_INPUT';
/**
+ * The name of the [TYPE_PROVIDER] input.
+ */
+ static const String TYPE_PROVIDER_INPUT = 'TYPE_PROVIDER_INPUT';
+
+ /**
* The task descriptor describing this kind of task.
*/
static final TaskDescriptor DESCRIPTOR = new TaskDescriptor(
@@ -3800,7 +3805,18 @@ class ResolveLibraryTypeNamesTask extends SourceBasedAnalysisTask {
@override
void internalPerform() {
+ //
+ // Prepare inputs.
+ //
LibraryElement library = getRequiredInput(LIBRARY_INPUT);
+ TypeProvider typeProvider = getRequiredInput(TYPE_PROVIDER_INPUT);
+ //
+ // Create the synthetic element for `loadLibrary`.
+ //
+ (library as LibraryElementImpl).createLoadLibraryFunction(typeProvider);
+ //
+ // Record outputs.
+ //
outputs[LIBRARY_ELEMENT5] = library;
}
@@ -3814,7 +3830,8 @@ class ResolveLibraryTypeNamesTask extends SourceBasedAnalysisTask {
return <String, TaskInput>{
'resolvedUnit': UNITS.of(source).toList((Source unit) =>
RESOLVED_UNIT3.of(new LibrarySpecificUnit(source, unit))),
- LIBRARY_INPUT: LIBRARY_ELEMENT4.of(source)
+ LIBRARY_INPUT: LIBRARY_ELEMENT4.of(source),
+ TYPE_PROVIDER_INPUT: TYPE_PROVIDER.of(AnalysisContextTarget.request)
};
}

Powered by Google App Engine
This is Rietveld 408576698