Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: DartScriptDebugServer.h

Issue 1405953008: Commit CL 1428333002 to Blink branch for Dart 1.13 (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/2171_4/Source/bindings/core/dart/
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: DartScriptDebugServer.h
===================================================================
--- DartScriptDebugServer.h (revision 202697)
+++ DartScriptDebugServer.h (working copy)
@@ -88,7 +88,13 @@
int removeByValue(T value)
{
int handle = m_valueToHandleMap.take(value);
- m_handleToValueMap.remove(handle);
+ // TODO(alanknight): This is clearly wrong. We should never call this
+ // with an invalid value, but we are doing so sometimes in isolate
+ // shutdown. We need to track down the underlying cause, but this
+ // is a workaround.
+ if (handle != 0) {
+ m_handleToValueMap.remove(handle);
+ }
return handle;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698