Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1405873002: Disable some GLAndSoftwareCompositing content browser tests under MSAN. (Closed)

Created:
5 years, 2 months ago by benwells
Modified:
5 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, chrome-apps-syd-reviews_chromium.org, ccameron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable some GLAndSoftwareCompositing content browser tests under MSAN. These tests give errors when run under MSAN. There is likely a real problem introduced recently (see bug for details). TBR=avi@chromium.org BUG=542896 Committed: https://crrev.com/47cd72d660d736695b0a2f2a2dedc8d189a6bbfe Cr-Commit-Position: refs/heads/master@{#354224}

Patch Set 1 #

Patch Set 2 : Fix oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -8 lines) Patch
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 8 chunks +63 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
benwells
5 years, 2 months ago (2015-10-15 05:00:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405873002/20001
5 years, 2 months ago (2015-10-15 05:00:49 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 05:14:48 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/47cd72d660d736695b0a2f2a2dedc8d189a6bbfe Cr-Commit-Position: refs/heads/master@{#354224}
5 years, 2 months ago (2015-10-15 05:15:49 UTC) #6
Avi (use Gerrit)
lgtm
5 years, 2 months ago (2015-10-15 15:28:16 UTC) #7
ccameron
4 years, 5 months ago (2016-07-18 18:39:26 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2159933002/ by ccameron@chromium.org.

The reason for reverting is: This has been fixed..

Powered by Google App Engine
This is Rietveld 408576698