Chrome power profiler service

content/browser/power_profiler/power_profiler_service.h

Index: content/browser/power_profiler/power_profiler_service.h
diff --git a/content/browser/power_profiler/power_profiler_service.h b/content/browser/power_profiler/power_profiler_service.h
new file mode 100644
index 0000000000000000000000000000000000000000..668faae6b19bb3436081ab6ee3fd41a58a30e751
--- /dev/null
+++ b/content/browser/power_profiler/power_profiler_service.h
@@ -0,0 +1,72 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_POWER_PROFILER_POWER_PROFILER_SERVICE_H_
+#define CONTENT_BROWSER_POWER_PROFILER_POWER_PROFILER_SERVICE_H_
+
+#include "base/basictypes.h"
+#include "base/memory/singleton.h"
+#include "base/observer_list.h"
+#include "base/task_runner.h"
+#include "base/timer/timer.h"
+#include "content/browser/power_profiler/power_data_provider.h"
+#include "content/browser/power_profiler/power_profiler_observer.h"
+#include "content/common/content_export.h"
+
+namespace content {
+
+// a class used to monitor the power usage and tell profiler the power data.

[jeremy, 2014/02/16 14:09:19]

nit: s/a/A/

[Pan, 2014/02/17 03:17:15]

Done.

+class CONTENT_EXPORT PowerProfilerService {
+ public:
+  static PowerProfilerService* GetInstance();
+
+  // Add and remove an observer.
+  void AddObserver(PowerProfilerObserver* observer);
+  void RemoveObserver(PowerProfilerObserver* observer);
+
+  bool IsAvailable();
+
+ private:
+  enum Status {
+    UNINITIALIZED, // Uninitialized.

[jeremy, 2014/02/16 14:09:19]

coding style is 2 space separation for line comments, here and elsewhere in the
cl.

[Pan, 2014/02/17 03:17:15]

Done.

+    INITIALIZED, // Initialized, not in profiling.
+    PROFILING, // In profiling.
+  };
+
+  friend struct DefaultSingletonTraits<PowerProfilerService>;
+  friend class PowerProfilerServiceTest;
+
+  PowerProfilerService();
+  virtual ~PowerProfilerService() {}
+
+  PowerProfilerService(scoped_ptr<PowerDataProvider> provider,
+                                scoped_refptr<base::TaskRunner> task_runner,

[jeremy, 2014/02/16 14:09:19]

I think the indentation here is off, I'd line these up with the upper 'scoped'
but other reviewers opinions may differ.

[Pan, 2014/02/17 03:17:15]

Done.

+                                const base::TimeDelta& delay);
+
+  void Start();
+  void Stop();
+
+  void QueryDataOnTaskRunner();
+  void QueryData();

[jeremy, 2014/02/16 14:09:19]

Function comments for these.

[Pan, 2014/02/17 03:17:15]

Done.

+
+  // Notify works in UI thread.

[jeremy, 2014/02/16 14:09:19]

// Executes on the UI thread.

[Pan, 2014/02/17 03:17:15]

Done.

+  void Notify(const PowerEventVector&);
+
+  base::RepeatingTimer<PowerProfilerService> query_power_timer_;
+  scoped_refptr<base::TaskRunner> task_runner_;
+
+  Status status_;
+
+  // Interval of reading the power data by provider.
+  const base::TimeDelta delay_;

[jeremy, 2014/02/16 14:09:19]

From the comment, it sounds like this should be renamed to sample_period_ ?

[Pan, 2014/02/17 03:17:15]

Done.

+  ObserverList<PowerProfilerObserver> observers_;
+
+  scoped_ptr<PowerDataProvider> data_provider_;
+
+  DISALLOW_COPY_AND_ASSIGN(PowerProfilerService);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_POWER_PROFILER_POWER_PROFILER_SERVICE_H_