Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: runtime/vm/snapshot.h

Issue 1405823003: Refactor ReadObjectImpl to use the as_reference field and eliminate ReadObjectRef and ReadInlinedOb… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-code-review-comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object_snapshot.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot.h
diff --git a/runtime/vm/snapshot.h b/runtime/vm/snapshot.h
index 0ad1b894329a6a798de83ede4ab32919d72b93d9..14360a4de7ba0d12c88d3d989791a85f2b25c2e4 100644
--- a/runtime/vm/snapshot.h
+++ b/runtime/vm/snapshot.h
@@ -485,19 +485,10 @@ class SnapshotReader : public BaseReader {
intptr_t patch_object_id,
intptr_t patch_offset);
- // Read an object reference from the stream.
- RawObject* ReadObjectRef(intptr_t object_id,
- intptr_t class_header,
- intptr_t tags,
- intptr_t patch_object_id = kInvalidPatchIndex,
- intptr_t patch_offset = 0);
-
- // Read an inlined object from the stream.
- RawObject* ReadInlinedObject(intptr_t object_id,
- intptr_t class_header,
- intptr_t tags,
- intptr_t patch_object_id,
- intptr_t patch_offset);
+ // Read a Dart Instance object.
+ RawObject* ReadInstance(intptr_t object_id,
+ intptr_t tags,
+ bool as_reference);
// Read a VM isolate object that was serialized as an Id.
RawObject* ReadVMIsolateObject(intptr_t object_id);
« no previous file with comments | « runtime/vm/raw_object_snapshot.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698