Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1405823002: DevTools: extract Blink-independent part of CPU profiler into V8ProfilerAgent (Closed)

Created:
5 years, 2 months ago by yurys
Modified:
5 years, 2 months ago
Reviewers:
dgozman, alph
CC:
chromium-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: extract Blink-independent part of CPU profiler into V8ProfilerAgent BUG=439376 Committed: https://crrev.com/a41c3653479277ddc6a2c5c4cda8fd09030c2d87 Cr-Commit-Position: refs/heads/master@{#354372}

Patch Set 1 #

Patch Set 2 : Removed some unused includes #

Patch Set 3 : Check if client is present before calling its methods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -391 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h View 1 2 chunks +12 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp View 1 2 1 chunk +38 lines, -250 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgent.h View 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.h View 1 chunk +62 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.cpp View 10 chunks +44 lines, -110 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (12 generated)
yurys
5 years, 2 months ago (2015-10-14 22:58:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405823002/1
5 years, 2 months ago (2015-10-14 23:00:01 UTC) #4
yurys
5 years, 2 months ago (2015-10-14 23:09:23 UTC) #5
dgozman
lgtm
5 years, 2 months ago (2015-10-14 23:33:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405823002/20001
5 years, 2 months ago (2015-10-14 23:37:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/126511)
5 years, 2 months ago (2015-10-15 01:04:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405823002/20001
5 years, 2 months ago (2015-10-15 01:06:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/120849)
5 years, 2 months ago (2015-10-15 02:14:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405823002/20001
5 years, 2 months ago (2015-10-15 18:12:55 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/126864)
5 years, 2 months ago (2015-10-15 19:39:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405823002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405823002/40001
5 years, 2 months ago (2015-10-15 20:45:00 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-15 21:56:02 UTC) #24
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 21:59:14 UTC) #25
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a41c3653479277ddc6a2c5c4cda8fd09030c2d87
Cr-Commit-Position: refs/heads/master@{#354372}

Powered by Google App Engine
This is Rietveld 408576698