Fix loop var inference when iterating on a type-param type.

Fix loop var inference when iterating on a type-param type.

Fixes https://github.com/dart-lang/dev_compiler/issues/336

R=jmesserly@google.com, leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/5ec298794bf70d1855d74321d63c635007d92578

[vsm, 2015-10-14 22:02:15]

vsm@google.com changed reviewers:
+ leafp@google.com

[Jennifer Messerly, 2015-10-14 23:10:11]

jmesserly@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2015-10-14 23:10:12]

lgtm

https://codereview.chromium.org/1405803003/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/1405803003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:389: class Foo<T
extends Iterable<String>> {
should we also add one like your example with two type args?

class Foo<S, T extends Iterable<S>> {
  void foo(T t) {
    for (var i in t) {
      int x = i; // error
      S y = i; // ok
    }
  }
}

[Leaf, 2015-10-14 23:38:54]

lgtm.

[vsm, 2015-10-15 03:05:12]

https://codereview.chromium.org/1405803003/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/1405803003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:389: class Foo<T
extends Iterable<String>> {
On 2015/10/14 23:10:12, John Messerly wrote:
> should we also add one like your example with two type args?
> 
> class Foo<S, T extends Iterable<S>> {
>   void foo(T t) {
>     for (var i in t) {
>       int x = i; // error
>       S y = i; // ok
>     }
>   }
> }

Done.

[vsm, 2015-10-15 03:05:30]

Committed patchset #2 (id:20001) manually as
5ec298794bf70d1855d74321d63c635007d92578 (presubmit successful).