ppapi/proxy/plugin_main_irt.h - Issue 140573003: Connect PPAPI IPC channels for non-SFI mode.

Side by Side Diff: ppapi/proxy/plugin_main_irt.h

Issue 140573003: Connect PPAPI IPC channels for non-SFI mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef PPAPI_PROXY_PLUGIN_MAIN_IRT_H_

	6 #define PPAPI_PROXY_PLUGIN_MAIN_IRT_H_

	7

	8 #include "ppapi/nacl_irt/irt_ppapi.h"

	9 #include "ppapi/proxy/ppapi_proxy_export.h"
	Mark Seaborn 2014/02/19 17:00:30 You shouldn't have PPAPI_PROXY_EXPORT here. That You shouldn't have PPAPI_PROXY_EXPORT here. That adds __attribute__((visibility("default"))), which is something we don't really want on Linux (it would override "-fvisibility=hidden" which most Chrome code is compiled with), and I think it won't affect code linked into the NaCl IRT. Mark Seaborn 2014/02/19 17:07:54 Oh, was PPAPI_PROXY_EXPORT just needed to make the Show quoted text On 2014/02/19 17:00:30, Mark Seaborn wrote: > You shouldn't have PPAPI_PROXY_EXPORT here. > > That adds __attribute__((visibility("default"))), which is something we > don't really want on Linux (it would override "-fvisibility=hidden" > which most Chrome code is compiled with), and I think it won't affect > code linked into the NaCl IRT. Oh, was PPAPI_PROXY_EXPORT just needed to make the components build work? In which case, it's OK as it is. hidehiko 2014/02/20 18:50:01 Exactly. Without this component build would be fai Show quoted text On 2014/02/19 17:07:54, Mark Seaborn wrote: > On 2014/02/19 17:00:30, Mark Seaborn wrote: > > You shouldn't have PPAPI_PROXY_EXPORT here. > > > > That adds __attribute__((visibility("default"))), which is something we > > don't really want on Linux (it would override "-fvisibility=hidden" > > which most Chrome code is compiled with), and I think it won't affect > > code linked into the NaCl IRT. > > Oh, was PPAPI_PROXY_EXPORT just needed to make the components build work? In > which case, it's OK as it is. Exactly. Without this component build would be failed.
	10

	11 #ifdef __cplusplus

	12 extern "C" {

	13 #endif

	14

	15 // The entry point for the main thread of the PPAPI plugin process.

	16 PPAPI_PROXY_EXPORT int PpapiPluginMain(void);

	17

	18 PPAPI_PROXY_EXPORT void PpapiPluginRegisterThreadCreator(

	19 const struct PP_ThreadFunctions* new_funcs);

	20

	21 // Overwrites the IPC channels for the browser and the renderer by the given
	Mark Seaborn 2014/02/19 17:00:30 "Overwrites" -> "Sets"? "Overwrites" -> "Sets"? hidehiko 2014/02/20 18:50:01 Done. Show quoted text On 2014/02/19 17:00:30, Mark Seaborn wrote: > "Overwrites" -> "Sets"? Done.
	22 // FD #s. This will be used for non-SFI mode. Must be called before
	Mark Seaborn 2014/02/19 17:00:30 Nit: '#s' -> 'numbers'. This will be read more th Nit: '#s' -> 'numbers'. This will be read more than it is written. :-) hidehiko 2014/02/20 18:50:01 Done :-) Show quoted text On 2014/02/19 17:00:30, Mark Seaborn wrote: > Nit: '#s' -> 'numbers'. This will be read more than it is written. :-) Done :-)
	23 // PpapiPluginMain is called.

	24 PPAPI_PROXY_EXPORT void SetIPCFileDescriptors(

	25 int browser_ipc_fd, int renderer_ipc_fd);

	26

	27 #ifdef __cplusplus

	28 }

	29 #endif

	30

	31 #endif // PPAPI_PROXY_PLUGIN_MAIN_IRT_H_

OLD	NEW

« components/nacl/loader/nonsfi/nonsfi_main.cc ('K') | « ppapi/proxy/irt_ppapi.c ('k') | ppapi/proxy/plugin_main_irt.cc » ('j') | ppapi/proxy/plugin_main_irt.cc » ('J')