core/src/fxge/dib/fx_dib_convert.cpp - Issue 1405723003: Sanity check the values of TRUE and FALSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/dib/fx_dib_convert.cpp

Issue 1405723003: Sanity check the values of TRUE and FALSE. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/dib/fx_dib_convert.cpp

diff --git a/core/src/fxge/dib/fx_dib_convert.cpp b/core/src/fxge/dib/fx_dib_convert.cpp

index 4b50a0cdf3b30c60c8c8ce676d9b243b8cbc246e..7e7a619595a735214d9c17544fb0e9f59264d7e8 100644

--- a/core/src/fxge/dib/fx_dib_convert.cpp

+++ b/core/src/fxge/dib/fx_dib_convert.cpp

@@ -1096,7 +1096,7 @@ CFX_DIBitmap* CFX_DIBSource::CloneConvert(FXDIB_Format dest_format,

}

FX_BOOL ret = TRUE;

CFX_DIBitmap* pSrcAlpha = NULL;

- if (m_AlphaFlag & 2) {

+ if (HasAlpha()) {

pSrcAlpha = (GetFormat() == FXDIB_Argb) ? GetAlphaMask() : m_pAlphaMask;

if (pSrcAlpha == NULL) {

delete pClone;

« no previous file with comments | « core/src/fxge/dib/fx_dib_composite.cpp ('k') | core/src/fxge/win32/fx_win32_dwrite.cpp » ('j') | no next file with comments »